check if _chosen_goal has value before accessing

[piliwilliam0306]

Bug fix

Fixed bug

if _chosen_goal doesn't have value, it may raise:

terminate called after throwing an instance of 'std::bad_optional_access'

This PR checks if _chosen_goal has value before accessing

[mxgrey]

Very good catch, you're right that this should not be here. I think it was a debug printout that should've been removed before it was merged into main.

I think we should actually remove the log entirely instead of protecting it with an if-statement since _find_plan is already logging all relevant updates about the chosen goal.

[piliwilliam0306]

Very good catch, you're right that this should not be here. I think it was a debug printout that should've been removed before it was merged into main.

I think we should actually remove the log entirely instead of protecting it with an if-statement since _find_plan is already logging all relevant updates about the chosen goal.

@mxgrey
Thanks for reviewing, removed!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (3be4edf) to head (288c36b).
Report is 117 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##             main   #406       +/-   ##
=========================================
- Coverage   17.61%      0   -17.62%     
=========================================
  Files         209      0      -209     
  Lines       19351      0    -19351     
  Branches     9297      0     -9297     
=========================================
- Hits         3409      0     -3409     
+ Misses      12274      0    -12274     
+ Partials     3668      0     -3668     

Flag	Coverage Δ
tests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 209 files with indirect coverage changes