-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check if _chosen_goal has value before accessing #406
Conversation
Signed-off-by: will <piliwilliam0306@gmail.com>
02f96dd
to
0299861
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good catch, you're right that this should not be here. I think it was a debug printout that should've been removed before it was merged into main
.
I think we should actually remove the log entirely instead of protecting it with an if-statement since _find_plan
is already logging all relevant updates about the chosen goal.
@mxgrey |
Head branch was pushed to by a user without write access
196c34c
to
01b181e
Compare
Signed-off-by: will <piliwilliam0306@gmail.com>
01b181e
to
d659f90
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #406 +/- ##
=========================================
- Coverage 17.61% 0 -17.62%
=========================================
Files 209 0 -209
Lines 19351 0 -19351
Branches 9297 0 -9297
=========================================
- Hits 3409 0 -3409
+ Misses 12274 0 -12274
+ Partials 3668 0 -3668
Flags with carried forward coverage won't be shown. Click here to find out more. |
Bug fix
Fixed bug
if
_chosen_goal
doesn't have value, it may raise:This PR checks if
_chosen_goal
has value before accessing