checking in a trivia addition to open-sauced/pizza-verse repo's "fact… #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s & trivia" page.
adiati98
requested changes
May 13, 2024
There was a problem hiding this comment.
Hey @prw760,
Thank you for your contribution! ✨
However, I see that you've added 3 items in this file.
Please read the README carefully and fix them accordingly.
Also, please change the title of the PR to follow our convention and make it short and clear. For example: feat: Add a pizza trivia.
Let me know if you have any questions or need help.
Thank you. 🙂
|
Sounds good, Ayu. I recreated the branch after syncing everything up --
and created a new PR. Thanks again! :)
…On Mon, May 13, 2024 at 12:02 AM Ayu Adiati ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Hey @prw760 <https://github.com/prw760>,
Thank you for your contribution! ✨
However, I see that you've added 3 items in this file.
Please read the README carefully and fix them accordingly.
Also, please change the title of the PR to follow our convention and make
it short and clear. For example: feat: Add a pizza trivia`.
Let me know if you have any questions or need help.
Thank you. 🙂
—
Reply to this email directly, view it on GitHub
<#88 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BDDT3IZRUKOBURNKZMZZUSDZCBQPXAVCNFSM6AAAAABHSOCN2OVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANJRHA2TAOBWGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s & trivia" page.
Description
I added a fun fact about pizza and a pizza trivia item to the associated page.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Related / Contributes to issue #36
Added to documentation?
[optional] What GIF best describes this PR or how it makes you feel?