Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some comments on translations #94

Open
LucyGwilliamAdmin opened this issue Jul 1, 2019 · 5 comments
Open

Some comments on translations #94

LucyGwilliamAdmin opened this issue Jul 1, 2019 · 5 comments

Comments

@LucyGwilliamAdmin
Copy link
Contributor

LucyGwilliamAdmin commented Jul 1, 2019

While in Kyrgyzstan it was brought up that some of the translations were quite right. As a follow up Nazira (Stats Kyrgyzstan) has sent this table with suggested translations:

image

Work has already been done so that countries can have custom line for
image
so will change this.

@LucyGwilliamAdmin
Copy link
Contributor Author

@brockfanning where do you add a custom line for the heading again? Can't find it

@brockfanning
Copy link
Collaborator

@LucyGwilliamAdmin I believe that was still undocumented, but I just added something about it here.

As for the translation updates, this is for Russian, correct? Would it be possible to submit the changes as a PR?

@LucyGwilliamAdmin
Copy link
Contributor Author

I have created a PR (#95) for 'Exploring data sources', 'Reported online' and 'Reporting status' but I don't think the functionality for 'Year' to be translated is there yet as currently only in English.

@LucyGwilliamAdmin
Copy link
Contributor Author

@brockfanning I've just tried adding those lines to the config file for the custom header and have got this error:

image

@LucyGwilliamAdmin
Copy link
Contributor Author

Actually, looks as if the build before had that error so probably not caused by this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants