Skip to content

Refactor/provider container #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1,449 commits into
base: dev
Choose a base branch
from
Open

Refactor/provider container #358

wants to merge 1,449 commits into from

Conversation

ragad-mohammed
Copy link
Contributor

This PR refactors the ProvConContainer component to improve code organization, maintainability, and type safety.

Changes made:

  • Extracted utility functions to providerUtils.ts
  • Created reusable JsonSection component
  • Added proper TypeScript interfaces in provider.types.ts
  • Improved code organization and maintainability

Technical Details:

  • Moved helper functions to a dedicated utils file for better reusability
  • Created a reusable JsonSection component for JSON tree visualization
  • Added TypeScript interfaces for better type safety
  • Improved code organization and reduced duplication
  • Enhanced maintainability with clear separation of concerns

Testing:
The refactoring maintains all existing functionality while making the code more modular and easier to test.

pinardo88 and others added 30 commits December 7, 2024 14:43
@pinardo88
Merge pull request #7 from oslabs-beta/PatriceFeature
7bb8211 
Created Functioning Vertical Sliders Per Route
@pinardo88
moved slider into each route component
c55b13f
@pinardo88
removed unnecessary flexbox and div
0f0b00e
@pinardo88
Merge pull request #8 from oslabs-beta/PatriceFeature
98498ab 
Refactor 'Route Description' and 'Action Container' for Visual Cleanliness
@garrettlchow
styled the clear button
d2864e6
@elliesimens
Merge branch 'dev' into feature/ellie
db39cb3
@garrettlchow
10950e8
@pinardo88
fix reflow/ repaint issue on snapshots
3566580
@pinardo88
Merge pull request #9 from oslabs-beta/PatriceFeature
2b0aec0 
fix reflow/ repaint issue on snapshots
@elliesimens
removed cartesian versus polar view due to polar view being nonfuncti…
1efadc0 
…onal
@elliesimens
Merge branch 'dev' into feature/ellie
dfa5eb6
@garrettlchow
styled clear button and route description header
cd86f25
@garrettlchow
Merge branch 'dev' into feature/garrett
8864b70
@garrettlchow
adjusted for fixed siwth of action container
4c1c412
@elliesimens
Merge pull request #10 from oslabs-beta/feature/ellie
d5183ba 
fix: Feature/ellie
@garrettlchow
fixed snapshot naming and current status of snapshots
e79c3c1
@garrettlchow
styled the actions in snapshots, working on slider
717f87d
@garrettlchow
styled slider thumb
46549c8
@garrettlchow
finished styling for slider and jump/current buttons
eaeb8a7
@garrettlchow
started styling collapse
d955152
@garrettlchow
Merge branch 'dev' into feature/garrett
5d933c4
@garrettlchow
removed override reducer code and updated version number to 26
f6eaf44
@garrettlchow
Merge pull request #11 from oslabs-beta/feature/garrett
72fa443 
Feature/garrett
@garrettlchow
removed current tab
9c4491b
@garrettlchow
styled collapse arrow
145eb4e
@garrettlchow
styled record text and added red circle
a1a08bb
@garrettlchow
styled record toggle
7e472a2
@garrettlchow
aligned collapse arrow
8a1631e
@garrettlchow
switched record toggle off ot gray
aa1a2b1
@ragad-mohammed
Provider/Consumer display complete
97fd9f1
garrettlchow and others added 30 commits January 2, 2025 10:34
@garrettlchow
added more logic to maintain localhost lock in chrome
ffe67f4
@garrettlchow
Merge pull request #38 from oslabs-beta/pls-work
cc571a0 
Pls work
@garrettlchow
reduced size of dark theme toggle
ea3f0d6
@garrettlchow
added dark theme toggle and reconnect button to tutorial
b62af49
@garrettlchow
updated hover event for main nav bar
8b74347
@garrettlchow
updated developer README
33c264c
@garrettlchow
updated developer read me link in read me
be59972
@garrettlchow
moved asset files
1525171
@garrettlchow
added v26 gifs to README
6fcf2df
@garrettlchow
reworked README with icons
83c7763
@garrettlchow
added more icons
e4d3a6f
@garrettlchow
updated new features of README
872cc45
@garrettlchow
updated getting started section of README
6487b6f
@garrettlchow
added more spacing for sections
016f34b
@garrettlchow
updated french README
688ad9f
@garrettlchow
updated different language READMEs
a89ea2d
@garrettlchow
fixed formatting for russian README'
999a52f
@garrettlchow
added medium article link
40f5fec
@garrettlchow
updated formating for medium article link
c784f3c
@garrettlchow
made medium link header
fcb4bf2
@garrettlchow
added link to CONTRIBUTING.md
47bafae
@garrettlchow
added missing tag to contributing
55f12d2
@garrettlchow
removed unused error handlers
f82426c
@garrettlchow
removed context menus permissions in chrome manifest
c47adf0
@garrettlchow
Merge pull request #39 from oslabs-beta/pls-work
17ae1e8 
Pls work
@garrettlchow
updated README to remove context mnenu option
0d0f4bb
@garrettlchow
added back context menu with port cleanup after window close
b2e67ab
@garrettlchow
fixed launching reactime in README
5dafcf3
@garrettlchow
added more error handling for finding localhost tab
c5be7e9
@ragad-mohammed
refactor: improve ProvConContainer modularity and type safety
6189874
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ragad-mohammed @pinardo88 @garrettlchow @elliesimens @dryczek01