feat(feature:loan): migrated to cmp #2404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nagarjuna0033
force-pushed
the
loan-module
branch
from
cd5823d to
439d900
Compare
revanthkumarJ
suggested changes
Jun 11, 2025
There was a problem hiding this comment.
@Nagarjuna0033 at many places you commenetd Toast parts and preview parts uncomment previews and remove toast
...oan/src/commonMain/kotlin/com/mifos/feature/loan/groupLoanAccount/GroupLoanAccountUiState.kt
Show resolved
Hide resolved
...n/src/commonMain/kotlin/com/mifos/feature/loan/groupLoanAccount/GroupLoanAccountViewModel.kt
Outdated
Show resolved
Hide resolved
.../loan/src/commonMain/kotlin/com/mifos/feature/loan/loanApproval/LoanAccountApprovalScreen.kt
Show resolved
Hide resolved
.../loan/src/commonMain/kotlin/com/mifos/feature/loan/loanApproval/LoanAccountApprovalScreen.kt
Outdated
Show resolved
Hide resolved
feature/loan/src/commonMain/kotlin/com/mifos/feature/loan/loanCharge/LoanChargeScreen.kt
Outdated
Show resolved
Hide resolved
feature/loan/src/commonMain/kotlin/com/mifos/feature/loan/loanCharge/LoanChargeScreen.kt
Outdated
Show resolved
Hide resolved
...loan/src/commonMain/kotlin/com/mifos/feature/loan/loanChargeDialog/LoanChargeDialogScreen.kt
Outdated
Show resolved
Hide resolved
...loan/src/commonMain/kotlin/com/mifos/feature/loan/loanChargeDialog/LoanChargeDialogScreen.kt
Outdated
Show resolved
Hide resolved
|
@Nagarjuna0033 don't remove previewProviders and previews and sample data for previews Let me know once you done all those i will review again. |
|
|
revanthkumarJ
approved these changes
Jun 19, 2025
|
@Nagarjuna0033 remove commented code |
kapmaurya
approved these changes
Jun 19, 2025
|
@Nagarjuna0033 by seeing above image the text field isn't aligned properly for eg the Loan term and Term drop-down, fix those and let me know |
|
@niyajali resolved that alignment |
niyajali
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes - Jira-#422
Didn't create a Jira ticket, click here to create new.
Please Add Screenshots If there are any UI changes.
Please make sure these boxes are checked before submitting your pull request - thanks!
Run the static analysis check
./gradlew checkorci-prepush.shto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.