Skip to content

fixed nav-bar icons #2387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bushra-aekay
Copy link

Description

  • This PR resolves the navbar language-icon issue and inconsistencies in the Navbar Icons Alignment.
  • Language Selector Icon Issue: On larger screens - an invisible clickable area was present next to the visible language selector. This has been fixed by ensuring the icon is no longer present in the DOM on larger screens, preventing the confusing interaction.
  • Icon Spacing Issue: The horizontal spacing between various icons (search, language, notifications, theme, user) in the toolbar was uneven. Made adjustments to the spacing to create a balanced and appealing layout.
  • Adjusted Language Icon Breakpoint: The breakpoint at which the language selector transitions from a small icon to a larger rectangular element has been adjusted to 960px. This resolves the issue of the small icon being invisible around the 959px width. Also adjusted the margin-left to give a uniform look.

File Changes :

  1. toolbar.component.html: Improved language selector responsiveness and toolbar spacing.
  2. search-tool.component.scss: Adjusted search icon spacing.
  3. toolbar.component.scss: Adjusted language icon display.

Dependencies:

  • No new external dependencies were introduced with this change.

Related issues and discussion

Web-122 (https://mifosforge.jira.com/browse/WEB-122)

Screenshots, if any

Navbar View (After fix)-
Screenshot 2025-04-07 164127

Navbar View (Before fix)-
image

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • If you have multiple commits please combine them into one commit by squashing them.

  • Read and understood the contribution guidelines at web-app/.github/CONTRIBUTING.md.

@steinwinde steinwinde self-requested a review April 11, 2025 14:49
Copy link
Collaborator

@steinwinde steinwinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Bushra, but could you please squash your commits, so only one remains? You can read about it here.

Fix: Improve Navbar Icon Alignment and Language Selector Responsiveness
@bushra-aekay
Copy link
Author

Thank you, Bushra, but could you please squash your commits, so only one remains? You can read about it here.

Done!

@steinwinde
Copy link
Collaborator

If you want to provide a new PR, please target the dev branch, not main. The dev branch is where all the progress happens from today on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants