Resolve Issue of Global Object Dependency by Implementing Local Collection in Converter Function #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzehl
reviewed
Apr 30, 2024
There was a problem hiding this comment.
@Peyman-N the formatting seems off in several places as if half of lines try to follow PEP8 the other not... can you double check this? otherwise I think the changes are okay. @apdavison I leave it to you
| if not pd.isna(openminds_techniques_cache): | ||
| techniques.extend(openminds_techniques_cache) | ||
| else: | ||
| warn(f"The {suffix} suffix is currently considered an auxiliary file for already existing techniques or a non technique file.") | ||
| warn( |
There was a problem hiding this comment.
The toolbox that I am using to make it PEP8 compliant keep adding this. I don't know why :/
I thought, I have deleted it.
There was a problem hiding this comment.
it makes the line length fit within the limit
|
I checked it for PEP8 using autopep8, but maybe it have a problem. can tell me which lines doesn't follow PEP8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a global object was causing a problem in running the code multiple times in series.
This pull request, solves this by creating a collection in converter function and pass it through each create function.