Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

creating person #36

Merged
merged 6 commits into from
May 16, 2024
Merged

Conversation

Peyman-N
Copy link
Member

@Peyman-N Peyman-N commented May 2, 2024

Using the Nameparser for extracting the authors list from BIDS datasets

@Peyman-N Peyman-N requested review from apdavison and lzehl May 2, 2024 14:28
@Peyman-N Peyman-N requested a review from apdavison May 13, 2024 19:16
Copy link
Member

@lzehl lzehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment in code and is from nameparser import HumanName really a dependency we need?

@apdavison
Copy link
Member

is from nameparser import HumanName really a dependency we need?

nameparser is a widely-used, well-supported package. The alternative is to write name parsing code ourselves, which will take time and will not give such good results.

@Peyman-N Peyman-N requested a review from lzehl May 15, 2024 08:50
Copy link
Member

@apdavison apdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@apdavison
Copy link
Member

@lzehl ok to merge this?

Copy link
Member

@lzehl lzehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only a small beautification, after that it can be merged

@lzehl lzehl merged commit deb2799 into openMetadataInitiative:main May 16, 2024
4 checks passed
@Peyman-N Peyman-N deleted the openminds_persons branch May 16, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants