creating person

bids2openminds/main.py

@@ -21,7 +21,7 @@ def create_openminds_person(full_name):
     family_name = person.last
 
     if person.middle:
-        alternate_names.append(person.full_name)
+        given_name = f"{given_name} {person.middle}"
 
     if person.nickname:
         alternate_names.append(person.nickname)

test/test_person.py

@@ -0,0 +1,22 @@
+# test for create_openminds_person function in the main
+import pytest
+from bids2openminds.main import create_openminds_person
+import openminds.latest.core as omcore
+
+# Test data: (full_name, given_name, family_name)
+example_names = [("John Ronald Reuel Tolkien", "John Ronald Reuel", "Tolkien"),
+                 ("Bilbo Baggins", "Bilbo", "Baggins")]
+
+
+@pytest.mark.parametrize("full_name,given_name,family_name", example_names)
+def test_create_openminds_person(full_name, given_name, family_name):
+    openminds_person_object = omcore.Person(given_name=given_name,
+                                            family_name=family_name)
+    bids2openminds_person_object = create_openminds_person(full_name)
+    assert openminds_person_object.given_name == bids2openminds_person_object.given_name, \
+        f"Given names don't match for input '{full_name}'"
+    assert openminds_person_object.family_name == bids2openminds_person_object.family_name, \
+        f"Family names don't match for input '{full_name}'"
+    assert openminds_person_object.type_ == bids2openminds_person_object.type_, \
+        f"Person types don't match for input '{full_name}'"
+    # assert openminds_person_object == bids2openminds_person_object