Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating File bundles #51

Merged
merged 10 commits into from
Jun 19, 2024
Merged

Creating File bundles #51

merged 10 commits into from
Jun 19, 2024

Conversation

Peyman-N
Copy link
Member

No description provided.

@Peyman-N Peyman-N requested review from lzehl and apdavison May 30, 2024 13:54
@Peyman-N Peyman-N linked an issue May 30, 2024 that may be closed by this pull request
file bundle registration #49
Closed
lzehl
lzehl requested changes Jun 5, 2024
View reviewed changes
@Peyman-N Peyman-N mentioned this pull request Jun 10, 2024
Closed
8 tasks
@Peyman-N Peyman-N requested a review from lzehl June 13, 2024 14:26
@apdavison
Copy link
Member

apdavison commented Jun 13, 2024 •
edited
Loading

This PR needs more tests:

  • test_bids_examples.py should be extended to count file bundles - @lzehl for each of the datasets tested there, please could you say how many file bundles you would expect to be generated?
  • test_file_bundle.py should be extended to explicitly test the various scenarios mentioned in file bundle registration #49

@apdavison apdavison mentioned this pull request Jun 13, 2024
Closed
@apdavison apdavison merged commit 2aed68f into openMetadataInitiative:main Jun 19, 2024
4 checks passed
@Peyman-N Peyman-N deleted the file_bundle branch October 17, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apdavison apdavison Awaiting requested review from apdavison

@lzehl lzehl Awaiting requested review from lzehl

Assignees

@Peyman-N Peyman-N

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

file bundle registration
3 participants
@Peyman-N @apdavison @lzehl