Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding content type to file repository and clarifying version of NIFTI for files #53

Merged
merged 6 commits into from
Jun 17, 2024

Conversation

Peyman-N
Copy link
Member

@Peyman-N Peyman-N commented Jun 3, 2024

No description provided.

@Peyman-N Peyman-N requested review from apdavison and lzehl June 3, 2024 06:36
Copy link
Member

@lzehl lzehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@apdavison looks okay to me

@lzehl
Copy link
Member

lzehl commented Jun 5, 2024

only comment: for not trying to load dummy files instead of setting an arbitrary file size you could also make use of the try/except functionality in python

@Peyman-N Peyman-N mentioned this pull request Jun 10, 2024
8 tasks
@Peyman-N Peyman-N requested a review from apdavison June 15, 2024 16:52
@apdavison apdavison merged commit 14ed965 into openMetadataInitiative:main Jun 17, 2024
4 checks passed
@Peyman-N Peyman-N deleted the ContentType branch June 19, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants