Solving the bugs caused by updating bids #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apdavison
reviewed
Sep 17, 2024
| @@ -1845,16 +1822,16 @@ | |||
| ], | |||
| "experimentalApproach": [ | |||
| { | |||
| "@id": "https://openminds.ebrains.eu/instances/experimentalApproach/anatomy" | |||
| "@id": "https://openminds.ebrains.eu/instances/experimentalApproach/neuroimaging" | |||
There was a problem hiding this comment.
this re-ordering seems fragile. I would expect this to break again in future. I suggest introducing sorting by @id
There was a problem hiding this comment.
Agreed, but should I add it to the openminds-python, or just sort it here?
As this was created by save method of the collection class in openminds-python, and then I have check it manually.
There was a problem hiding this comment.
yes, this should be done in openminds-Python
Merged
lzehl
reviewed
Jan 29, 2025
| @@ -118,7 +118,7 @@ | |||
| { | |||
| "@id": "_:000010", | |||
| "@type": "https://openminds.ebrains.eu/core/FileRepository", | |||
| "IRI": "file:///home/peyman-user/Desktop/data/bids_test/bids-examples/eeg_rest_fmri", | |||
| "IRI": "file:///home/peyman-user/Desktop/Code/bids-examples/eeg_rest_fmri", | |||
There was a problem hiding this comment.
I'm confused. Why is this a local path? should this not be a path on GitHub?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.