Discouraged support for custom datasets inside the particlesPath

openPMD · Feb 15, 2024 · c31cd52 · c31cd52
1 parent 27be452
commit c31cd52
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 10 deletions.
diff --git a/src/CustomHierarchy.cpp b/src/CustomHierarchy.cpp
@@ -474,8 +474,18 @@ void CustomHierarchy::read(
     {
         switch (mpp.determineType(currentPath))
         {
-            // Group is a bit of an internal misnomer here, it just means that
-            // it matches neither meshes nor particles path
+
+        case internal::ContainedType::Particle:
+            std::cerr << "[Warning] Dataset found at '"
+                      << (concatWithSep(currentPath, "/") + "/" + path)
+                      << "' inside the particles path. A particle species is "
+                         "always a group, never a dataset. Will parse as a "
+                         "custom dataset. Storing custom datasets inside the "
+                         "particles path is discouraged."
+                      << std::endl;
+            [[fallthrough]];
+        // Group is a bit of an internal misnomer here, it just means that
+        // it matches neither meshes nor particles path
         case internal::ContainedType::Group: {
             auto &rc = data.embeddedDatasets()[path];
             Parameter<Operation::OPEN_DATASET> dOpen;
@@ -513,14 +523,6 @@ void CustomHierarchy::read(
                 meshesMap.forget(path);
             }
             break;
-        case internal::ContainedType::Particle:
-            std::cerr
-                << "[Warning] Dataset found at '"
-                << (concatWithSep(currentPath, "/") + "/" + path)
-                << " that matches one of the given particle paths. A particle "
-                   "species is always a group, never a dataset. Will skip."
-                << std::endl;
-            break;
         }
     }
 

diff --git a/test/CoreTest.cpp b/test/CoreTest.cpp
@@ -402,6 +402,12 @@ TEST_CASE("custom_hierarchies_no_rw", "[core]")
                 .asContainerOf<ParticleSpecies>()["e"]["position"]["x"];
         e_pos_x.resetDataset({Datatype::INT, {10}});
         e_pos_x.storeChunk(data, {0}, {10});
+
+        auto gnihihi = write.iterations[0]["custom_particles"]["particles"]
+                           .asContainerOf<RecordComponent>();
+        auto dataset = gnihihi["custom_dataset"];
+        dataset.resetDataset({Datatype::INT, {10}});
+        dataset.storeChunk(std::unique_ptr<int[]>(new int[10]{}), {0}, {10});
         write.close();
     }