Derive PatchComponent from RecordComponent #1594
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PatchRecordComponent
uselessly duplicates lots of logic fromRecordComponent
and lots of functionality fromRecordComponent
is missing inParticlePatches
, e.g. selective chunk loading. This is crucial in streaming setups where loading the entire particle patches information results in NxM communication patterns.TODO:
Keeping them separate for now keeps the diff smallerBaseRecordComponent
is now useless and can be merged withRecordComponent
Alternatively, move a large part of theThat separation would imply having to separate the flush/read logic again.RecordComponent
logic toBaseRecordComponent
and keep only those parts inRecordComponent
that really should not be part ofPatchRecordComponent