Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive PatchComponent from RecordComponent #1594

Merged

Conversation

franzpoeschel
Copy link
Contributor

@franzpoeschel franzpoeschel commented Feb 13, 2024

PatchRecordComponent uselessly duplicates lots of logic from RecordComponent and lots of functionality from RecordComponent is missing in ParticlePatches, e.g. selective chunk loading. This is crucial in streaming setups where loading the entire particle patches information results in NxM communication patterns.

TODO:

  • BaseRecordComponent is now useless and can be merged with RecordComponent Keeping them separate for now keeps the diff smaller
  • Alternatively, move a large part of the RecordComponent logic to BaseRecordComponent and keep only those parts in RecordComponent that really should not be part of PatchRecordComponent That separation would imply having to separate the flush/read logic again.

Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks great (incl Python update).

@ax3l ax3l merged commit 283b2fe into openPMD:dev Feb 13, 2024
31 checks passed
@ax3l ax3l self-assigned this Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants