-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADIOS2: Require v2.9 as minimum #1711
Conversation
a37e2be
to
bef5605
Compare
59d323d
to
e2cdeac
Compare
For some reason, ADIOS2 has trouble linking against C-Blosc2 with clang6 and clang7. clang14 works, bisecting this would be too much trouble.
|
This reverts commit 1740136.
a8bb3f1
to
224ecb2
Compare
@@ -12,7 +12,7 @@ spack: | |||
|
|||
packages: | |||
adios2: | |||
variants: ~zfp ~sz ~png ~dataman ~python ~fortran ~ssc ~shared ~bzip2 | |||
variants: ~zfp ~sz ~png ~dataman ~python ~fortran ~ssc ~shared ~bzip2 ~blosc2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That we need to disable blosc2 is concerning, but maybe we can disable it again with #1597
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thank you!
Version 2.9 has modifiable attributes which are necessary for properly implementing variable-based encoding.
TODO