Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADIOS2: Require v2.9 as minimum #1711

Merged
merged 16 commits into from
Feb 18, 2025
Merged

Conversation

franzpoeschel
Copy link
Contributor

@franzpoeschel franzpoeschel commented Jan 15, 2025

Version 2.9 has modifiable attributes which are necessary for properly implementing variable-based encoding.

TODO

  • Require ADIOS2 v2.9 in CMake
  • Remove version guards for v2.8 and v2.9 from the C++ codebase
  • Update CI
  • Documentation
  • The clang-7/8 installations of ADIOS2 v2.9 fail building Blosc2 as a dependecy due to some missing intrinsic? Also one of them fails building mgard. Maybe report.

@franzpoeschel franzpoeschel added backend: ADIOS2 continuous integration dependencies Pull requests that update a dependency file labels Jan 15, 2025
@franzpoeschel franzpoeschel force-pushed the adios2-bump-to-v29 branch 3 times, most recently from 59d323d to e2cdeac Compare February 3, 2025 16:06
@franzpoeschel
Copy link
Contributor Author

franzpoeschel commented Feb 3, 2025

For some reason, ADIOS2 has trouble linking against C-Blosc2 with clang6 and clang7. clang14 works, bisecting this would be too much trouble.

     984     /home/franzpoeschel/workspace/singularity_openpmd/spack/lib/spack/env/clang/clang++ -O3 -DNDEBUG CMakeFiles/adios2_remote_server.dir/remote_server.cpp.o CMakeFiles/adios2_remote_s 
             erver.dir/remote_common.cpp.o -o ../../../../bin/adios2_remote_server  -Wl,-rpath,/tmp/franzpoeschel/spack-stage/spack-stage-adios2-2.10.0-bjro7kiefbluehobn35oxvnrooqsgqak/spack-b 
             uild-bjro7ki/lib:/home/franzpoeschel/workspace/singularity_openpmd/spack/opt/spack/linux-ubuntu20.04-x86_64/clang-7.0.0/c-blosc2-2.11.1-qgxv3lsjj77sukwj2i3za35gpj66pxzu/lib:/home/ 
             franzpoeschel/workspace/singularity_openpmd/spack/opt/spack/linux-ubuntu20.04-x86_64/clang-7.0.0/zstd-1.5.6-2wui5irvaceh3ybks5p6es24tbr7ioq7/lib:/home/franzpoeschel/workspace/sing 
             ularity_openpmd/spack/opt/spack/linux-ubuntu20.04-x86_64/clang-7.0.0/lz4-1.9.4-imjreiyroqm4itvhjdnrc7xllbylqhrr/lib:/home/franzpoeschel/workspace/singularity_openpmd/spack/opt/spa 
             ck/linux-ubuntu20.04-x86_64/clang-7.0.0/zlib-ng-2.1.6-m5ec7k47kaawspqhc4vv6xcysggg3yub/lib::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::: 
             ::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::: 
             ::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::: 
             ::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::: 
             ::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::: 
             ::::::::::::::::::::: ../../../../lib/libadios2_evpath.so.2.10.0 ../../../../lib/libadios2_core.so.2.10.0 ../../../../lib/libadios2_ffs.so.2.10.0 ../../../../lib/libadios2_atl.so. 
             2.10.0 -pthread -ldl -Wl,-rpath-link,/tmp/franzpoeschel/spack-stage/spack-stage-adios2-2.10.0-bjro7kiefbluehobn35oxvnrooqsgqak/spack-build-bjro7ki/lib:/home/franzpoeschel/workspac 
             e/singularity_openpmd/spack/opt/spack/linux-ubuntu20.04-x86_64/clang-7.0.0/c-blosc2-2.11.1-qgxv3lsjj77sukwj2i3za35gpj66pxzu/lib:/home/franzpoeschel/workspace/singularity_openpmd/s 
             pack/opt/spack/linux-ubuntu20.04-x86_64/clang-7.0.0/zstd-1.5.6-2wui5irvaceh3ybks5p6es24tbr7ioq7/lib:/home/franzpoeschel/workspace/singularity_openpmd/spack/opt/spack/linux-ubuntu2 
             0.04-x86_64/clang-7.0.0/lz4-1.9.4-imjreiyroqm4itvhjdnrc7xllbylqhrr/lib:/home/franzpoeschel/workspace/singularity_openpmd/spack/opt/spack/linux-ubuntu20.04-x86_64/clang-7.0.0/zlib- 
             ng-2.1.6-m5ec7k47kaawspqhc4vv6xcysggg3yub/lib                                                                                                                                       
  >> 985     /usr/bin/ld: /home/franzpoeschel/workspace/singularity_openpmd/spack/opt/spack/linux-ubuntu20.04-x86_64/clang-7.0.0/c-blosc2-2.11.1-qgxv3lsjj77sukwj2i3za35gpj66pxzu/lib/libblosc2. 
             so.2: undefined reference to `_xgetbv'

@@ -12,7 +12,7 @@ spack:

packages:
adios2:
variants: ~zfp ~sz ~png ~dataman ~python ~fortran ~ssc ~shared ~bzip2
variants: ~zfp ~sz ~png ~dataman ~python ~fortran ~ssc ~shared ~bzip2 ~blosc2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That we need to disable blosc2 is concerning, but maybe we can disable it again with #1597

Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you!

@ax3l ax3l merged commit 8cace7e into openPMD:dev Feb 18, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend: ADIOS2 continuous integration dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants