work in progress

- button / switch off not reliable?
- display of process not in all cases

Author: amandel

.github/fake-cc

@@ -77,7 +77,7 @@ Gps gps;
 static const long BLUETOOTH_INTERVAL_MILLIS = 100;
 static long lastBluetoothInterval = 0;
 
-static const long DISPLAY_INTERVAL_MILLIS = 200;
+static const long DISPLAY_INTERVAL_MILLIS = 300;
 static long lastDisplayInterval = 0;
 
 float TemperatureValue = -1;
@@ -103,7 +103,7 @@ CircularBuffer<DataSet*, 10> dataBuffer;
 FileWriter* writer;
 
 const uint8_t displayAddress = 0x3c;
-const uint16_t BUTTON_PRESS_THRESHOLD_FOR_SHUTDOWN_MS = 10000;
+constexpr uint16_t BUTTON_PRESS_THRESHOLD_FOR_SHUTDOWN_MS = 5000;
 
 // Enable dev-mode. Allows to
 // - set wifi config
@@ -235,26 +235,29 @@ static uint8_t shutdownState = 0;
 static unsigned long timeOfLastPowerKeepAlive = 0;
 static void powerKeepAliveTimerISR()
 {
+  unsigned long now = millis();
+
   // Send "keep alive" trigger to power management module
   // This is done by toggling the pin every 300 ms or more
   if(shutdownState == 0)
   {
-    unsigned long timeSinceLastPowerKeepAlive = millis() - timeOfLastPowerKeepAlive;
+    unsigned long timeSinceLastPowerKeepAlive = now - timeOfLastPowerKeepAlive;
     bool ip5306ButtonState = digitalRead(IP5306_BUTTON);
 
     if(!ip5306ButtonState && timeSinceLastPowerKeepAlive > POWER_KEEP_ALIVE_INTERVAL_MS)
     {
-      timeOfLastPowerKeepAlive = millis();
+      timeOfLastPowerKeepAlive = now;
       digitalWrite(IP5306_BUTTON, HIGH);
     }
     else if(ip5306ButtonState && timeSinceLastPowerKeepAlive > 300)
     {
-      timeOfLastPowerKeepAlive = millis();
+      timeOfLastPowerKeepAlive = now;
       digitalWrite(IP5306_BUTTON, LOW);
     }
   }
 
-  if(shutdownState == 0 && button.read() && button.getCurrentStateMillis() >= BUTTON_PRESS_THRESHOLD_FOR_SHUTDOWN_MS) {
+  if(shutdownState == 0 && button.handle(now)
+    && button.getCurrentStateMillis() >= BUTTON_PRESS_THRESHOLD_FOR_SHUTDOWN_MS) {
     shutdownState = 1;
   }
   switch(shutdownState)

.idea/codeStyles/Project.xml

@@ -509,6 +509,7 @@ String getIp() {
 }
 
 void updateDisplay(DisplayDevice * const display, String action = "") {
+  obsDisplay->handleShutdownDisplay();
   if (action.isEmpty()) {
     display->showTextOnGrid(0, 0, "Ver.:");
     display->showTextOnGrid(1, 0, OBSVersion);
@@ -2068,6 +2069,7 @@ void configServerHandle() {
   if (obsImprov) {
     obsImprov->handle();
   }
+  obsDisplay->handleShutdownDisplay();
 }
 
 std::vector<std::pair<String,String>> extractParameters(HTTPRequest *req) {

README.md

@@ -54,6 +54,30 @@ void DisplayDevice::displaySimple(uint16_t value) {
   this->prepareTextOnGrid(3, 2, "cm", MEDIUM_FONT, -7, -5);
 }
 
+bool startedShutdownDisplay = false;
+
+bool DisplayDevice::handleShutdownDisplay()
+{
+  bool updated = false;
+#ifdef OBSPRO
+  bool buttonPressed = button.getState();
+  if (buttonPressed && button.getCurrentStateMillis() > 3000)
+  {
+    auto pressTimeMs = button.getCurrentStateMillis() - 3000;
+    // black out the display from top to bottom for so that after 7000 ms the whole display is black
+    auto linesToFill = (pressTimeMs * 64) / (BUTTON_PRESS_THRESHOLD_FOR_SHUTDOWN_MS - 3000);
+
+    m_display->drawBox(0, 0, 128, linesToFill);
+    startedShutdownDisplay = true;
+  } else if (startedShutdownDisplay) {
+    startedShutdownDisplay = false;
+    clear();
+    updated = true;
+  }
+#endif
+  return updated;
+}
+
 void DisplayDevice::showValues(
   uint16_t sensor1MinDistance, const char* sensor1Location, uint16_t sensor1RawDistance,
   uint16_t sensor2MinDistance, const char* sensor2Location, uint16_t sensor2RawDistance, uint16_t sensor2Distance,
@@ -138,9 +162,8 @@ void DisplayDevice::showValues(
     if(BMP280_active == true)
       showTemperatureValue(TemperaturValue);
   }
-
+  handleShutdownDisplay();
   m_display->updateDisplay();
-
 }
 
 void DisplayDevice::showGPS(uint8_t sats) {

src/OpenBikeSensorFirmware.cpp

@@ -100,6 +100,7 @@ class DisplayDevice {
     uint8_t scrollUp();
     uint8_t startLine();
     void highlight(uint32_t highlightTimeMillis = 500);
+    bool handleShutdownDisplay();
 
     //##############################################################
     // Basic display configuration

src/configServer.cpp

@@ -73,5 +73,6 @@ extern Gps gps;
 
 extern const uint8_t LEFT_SENSOR_ID;
 extern const uint8_t RIGHT_SENSOR_ID;
+extern const uint16_t BUTTON_PRESS_THRESHOLD_FOR_SHUTDOWN_MS;
 
 #endif

src/displays.cpp

@@ -31,11 +31,11 @@ Button::Button(int pin) : mPin(pin) {
   mLastState = mLastRawState = read();
 }
 
-void Button::handle() {
-  handle(millis());
+bool Button::handle() {
+  return handle(millis());
 }
 
-void Button::handle(unsigned long millis) {
+bool Button::handle(unsigned long millis) {
   const int state = read();
 
   if (state != mLastRawState) {
@@ -52,6 +52,7 @@ void Button::handle(unsigned long millis) {
       mReleaseEvents++;
     }
   }
+  return state;
 }
 
 bool Button::gotPressed() {

src/displays.h

@@ -28,8 +28,8 @@
 class Button {
   public:
     explicit Button(int pin);
-    void handle();
-    void handle(unsigned long millis);
+    bool handle();
+    bool handle(unsigned long millis);
     int read() const;
     int getState() const;
     bool gotPressed();