-
Notifications
You must be signed in to change notification settings - Fork 28
Verify server certificates against the full Mozilla trust store #365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify server certificates against the full Mozilla trust store #365
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the contribution!
I can add the steps to the Github actions build. I hope to fine the time to do this as well as building the pro & classic code in one go. If I don't find the time till near next release we merge it as is :) |
|
Great to have the certs update integrated in the build! The CI build now fails giving:
|
0e08941
to
beb1ef6
Compare
beb1ef6
to
c4a0b65
Compare
e36727a
to
4532430
Compare
Slowly getting my feet wet with GH actions; looks better now: https://github.com/schiermi/OpenBikeSensorFirmware/actions/runs/10874202448/job/30171220169 |
A build containing those changes was tested for three weeks "on the bike". Testing included track uploads, OBS webinterface access & ALP data downloads.
This PR increases the compiled firmware size by ~60 kb.
It should be beneficial to include the instructions found in
src/truststore/README.md
to update the binary trust storesrc/truststore/x509_crt_bundle
into the Github actions pipeline for new builds, but I'm missing knowledge for this task.