Skip to content

Soft-off after 10 seconds not earlier #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Soft-off after 10 seconds not earlier #375

Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3d03378
Soft-off after 10 seconds not earlier
amandel Feb 28, 2025
f430612
Use the Button class, introduce constant.
amandel Feb 28, 2025
2876fd8
Merge branch 'main' into feature/delay-soft-switch-off
amandel Feb 28, 2025
25060da
Merge branch 'main' into feature/delay-soft-switch-off
amandel Feb 28, 2025
45fde04
read button only once
amandel Feb 28, 2025
76b3be3
work in progress
amandel Feb 28, 2025
ae49d6a
Merge branch 'main' into feature/delay-soft-switch-off
amandel Mar 2, 2025
22cf8dd
Merge branch 'main' into feature/delay-soft-switch-off
amandel Mar 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 5 additions & 14 deletions src/OpenBikeSensorFirmware.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ CircularBuffer<DataSet*, 10> dataBuffer;
FileWriter* writer;

const uint8_t displayAddress = 0x3c;

const uint16_t BUTTON_PRESS_THRESHOLD_FOR_SHUTDOWN_MS = 10000;

// Enable dev-mode. Allows to
// - set wifi config
Expand Down Expand Up @@ -233,35 +233,26 @@ static uint8_t shutdownState = 0;
// Power-management keep alive timer
// This function is called every 100 ms
static unsigned long timeOfLastPowerKeepAlive = 0;
static uint8_t buttonPressedCounter = 0;
static void powerKeepAliveTimerISR()
{
// Send "keep alive" trigger to power management module
// This is done by toggling the pin every 300 ms or more
if(shutdownState == 0)
{
if(!digitalRead(IP5306_BUTTON) && millis() - timeOfLastPowerKeepAlive > POWER_KEEP_ALIVE_INTERVAL_MS)
unsigned long timeSinceLastPowerKeepAlive = millis() - timeOfLastPowerKeepAlive;
if(!digitalRead(IP5306_BUTTON) && timeSinceLastPowerKeepAlive > POWER_KEEP_ALIVE_INTERVAL_MS)
{
timeOfLastPowerKeepAlive = millis();
digitalWrite(IP5306_BUTTON, HIGH);
}
else if(digitalRead(IP5306_BUTTON) && millis() - timeOfLastPowerKeepAlive > 300)
else if(digitalRead(IP5306_BUTTON) && timeSinceLastPowerKeepAlive > 300)
{
timeOfLastPowerKeepAlive = millis();
digitalWrite(IP5306_BUTTON, LOW);
}
}

// Soft power-off OBSPro when button is pressed for more than 2 seconds
if(button.read())
{
if(buttonPressedCounter < 255)
buttonPressedCounter++;
}
else
buttonPressedCounter = 0;

if(shutdownState == 0 && buttonPressedCounter >= 50) {
if(shutdownState == 0 && button.read() && button.getCurrentStateMillis() >= BUTTON_PRESS_THRESHOLD_FOR_SHUTDOWN_MS) {
shutdownState = 1;
}
switch(shutdownState)
Expand Down