Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix entering single date in date range picker #1119

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Arnei
Copy link
Member

@Arnei Arnei commented Feb 25, 2025

When filtering by start date and entering the date by hand, pressing enter after writing only a single date should still result in a filter for that day.
For example, 01/01/2025 results in a range of 01/01/2025 - 01/01/2025. This fixes that.

How to test this

Can be tested as usual. Test if all input methods for the datepicker still work (both mouse and keyboard). Ideally also test other datepickers beside the start date filter, e.g. the one for scheduling events.

When filtering by start date and entering the date by hand,
pressing enter after writing only a single date should still result
in a filter for that day.
For example, 01/01/2025 results in a range of 01/01/2025 - 01/01/2025.
This fixes that.
@Arnei Arnei added the type:bug Something isn't working label Feb 25, 2025
Copy link
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-1119

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-1119

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

Copy link
Contributor

This pull request is deployed at test.admin-interface.opencast.org/1119/2025-02-25_08-03-04/ .
It might take a few minutes for it to become available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant