Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple CI test #347

Merged
merged 2 commits into from
May 21, 2024
Merged

Add simple CI test #347

merged 2 commits into from
May 21, 2024

Conversation

lkiesow
Copy link
Member

@lkiesow lkiesow commented May 6, 2024

This patch adds a simple CI workflow to test if the dependencies can be downloaded and the project actually builds.

This patch adds a simple CI workflow to test if the dependencies can be
downloaded and the project actually builds.
@ziegenberg
Copy link
Member

@lkiesow, would this be ok to be merged now?

@lkiesow
Copy link
Member Author

lkiesow commented May 14, 2024

The build still fails with warnings. We need to fix that first

@ziegenberg
Copy link
Member

Could we add this with CI=false so we at least know it builds, and when we remove all warnings, we can set CI=true? So we can get gradually more CI.

Just to get a simple CI started, this patch sets `CI=false` for now. Hopefully we can get this working with `CI=true` soon.
Copy link
Member

@ziegenberg ziegenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good now; let's get this in and improve gradually from here on.

@ziegenberg
Copy link
Member

And it already found a build error... :D

Will be fixed by #404

@ziegenberg
Copy link
Member

But as they are unrelated I will merge this now.

@ziegenberg ziegenberg merged commit 4e8106c into opencast:main May 21, 2024
1 of 2 checks passed
@ziegenberg ziegenberg self-assigned this May 21, 2024
@ziegenberg ziegenberg added the type:code-enhancement Internal improvements to the codebase label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:code-enhancement Internal improvements to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants