Fix selected filter being lost on tab switch #980
Conversation
When for example setting a filter for the events table, then switching to the series table and then switching back to the events table, the previously set filter will be lost. This change preserves the filter instead.
|
This pull request is deployed at test.admin-interface.opencast.org/980/2024-11-12_11-05-59/ . |
|
Use Run test server using develop.opencast.org as backend: Specify a different backend like stable.opencast.org: It may take a few seconds for the interface to spin up. |
|
Thanks for the fix! I have tested it and it works as expected, filters are now persisted when I switch between event and series view. |
|
Thanks for catching that. I am not able to reproduce the bug you found. Do you have futher information? I also tested against develop.opencast.org. |
|
I am also not able to reproduce this. I tested the quick filter on a testing server with opencast 16.7. I was also able to use multiple quick filters and the filters from the list. Everything worked es expected. |
|
Use Run test server using develop.opencast.org as backend: Specify a different backend like stable.opencast.org: It may take a few seconds for the interface to spin up. |
We should also be refetching filters when we open a new table anyway.
Arnei
force-pushed
the
save-selected-filter
branch
from
b7893a2 to
8878c28
Compare
|
This pull request is deployed at test.admin-interface.opencast.org/980/2025-02-21_10-28-02/ . |
|
This pull request has conflicts ☹ |
|
This pull request has conflicts ☹ |
|
This doesn't seem to work for me, even after clearing cache and cookies. Looking at the developer console, I see a query to |
|
That should not be the cause. Also, just checked and it still works for me. Do you have more details? |
|
This pull request has conflicts ☹ |
Includes opencast#980, supersedes opencast#1083. Should achieve the same thing as opencast#1083, but without reverting to older dependency versions. Meaning clicking on a series name in the series table should bring up the events table with the series filter set. Including opencast#980 as it helps in achieving this.
|
This is working for me and the code looks reasonable. When switching from the videos table to series, I also get the error Greg mentioned, but that happens on main as well and has been for a while iirc. Could be the cause of the original error, but I'm not sure. Also not sure how to proceed here to be honest. It's working for Arne, Martin and me, but Lars and Greg have errors... sooo yeah no clue, sorry for this more or less useless comment. |
Includes opencast#980, supersedes opencast#1083. Should achieve the same thing as opencast#1083, but without reverting to older dependency versions. Meaning clicking on a series name in the series table should bring up the events table with the series filter set. Including opencast#980 as it helps in achieving this.
The "resource" variable in the table might not be up to date on page load. Therefore, we pass it to the getFilters method ourselves, so that api requests immediately use the correct filters.
|
I found a problem that I was not able to reproduce on develop.opencast.org, its related to lars comment presentation-ca627caf-5ed0-48b3-bf9c-c69cf9d8bbcf.mp4 |
|
I have seen this behaviour on main and am fairly confident that #1121 will fix it. |
|
@lkiesow @gregorydlogan I would merge it, and if it introduces bugs, we can fix them later. Any concerns? |
Fixes #552.
When for example setting a filter for the events table, then switching to the series table and then switching back to the events table, the previously set filter will be lost. This change preserves the filter instead.
When testing this, you may need to clear your browser cache for this to work.
Quick showcase:
Bildschirmaufzeichnung vom 2024-11-12 12-03-42.webm