Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfiles: Legacy key/value format with whitespace separator should not be used #804

Open
jiridanek opened this issue Dec 11, 2024 · 3 comments
Assignees
Labels
good first issue Good for newcomers kind/bug Something isn't working

Comments

@jiridanek
Copy link
Member

"ENV key=value" should be used instead of legacy "ENV key value" format

2024/12/11 11:37:32 LegacyKeyValueFormat%!(EXTRA string=Legacy key/value format with whitespace separator should not be used, string=https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/, string="ENV key=value" should be used instead of legacy "ENV key value" format, []parser.Range=[{{22 0} {22 0}}])
@jiridanek jiridanek added the kind/bug Something isn't working label Dec 11, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in ODH IDE Planning Dec 11, 2024
@jstourac jstourac added the good first issue Good for newcomers label Jan 29, 2025
jstetina added a commit to jstetina/odh-notebooks that referenced this issue Feb 19, 2025
@andyatmiami andyatmiami self-assigned this Feb 19, 2025
@andyatmiami
Copy link
Contributor

I am working on this as a byproduct of the refactoring we are doing for Konflux migration.

@jiridanek
Copy link
Member Author

jiridanek commented Feb 19, 2025

Personally, I'd merge it (the improved version of #906 that you've already put together). It is innocuous change, and (ideally) we should try to make progress one small PR at a time...

but, I do understand your reluctance, as this can easily cause annoying merge conflicts in whatever you're working on.

So yeah, let's andy handle it.

@andyatmiami
Copy link
Contributor

FWIW - change will initially appear on https://github.com/opendatahub-io/notebooks/tree/refactor/konflux-migration

and I hope to have something pushed by tomorrow 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers kind/bug Something isn't working
Projects
Status: 📋 Backlog
Development

Successfully merging a pull request may close this issue.

3 participants