Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add '=' to ENV directives in Dockerfiles #906

Closed
wants to merge 1 commit into from
Closed

fix: add '=' to ENV directives in Dockerfiles #906

wants to merge 1 commit into from

Conversation

jstetina
Copy link

Closes #804

Add '=' to env variable directives in dockerfiles

Description

How Has This Been Tested?

Tested using command:
docker buildx build --check -f cuda/ubi9-python-3.11/Dockerfile . --build-arg BASE_IMAGE=ubuntu

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 19, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign harshad16 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 19, 2025

Hi @jstetina. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the size/l label Feb 19, 2025
@jstetina jstetina closed this Feb 19, 2025
@jstetina jstetina deleted the dockerfile-env-warning-fix branch February 19, 2025 16:02
@jiridanek jiridanek mentioned this pull request Feb 19, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyatmiami andyatmiami Awaiting requested review from andyatmiami

@paulovmr paulovmr Awaiting requested review from paulovmr

Assignees
No one assigned
Labels
needs-ok-to-test size/l
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dockerfiles: Legacy key/value format with whitespace separator should not be used
1 participant
@jstetina