-
Notifications
You must be signed in to change notification settings - Fork 25
feat!: remove Transifex calls for OEP-58 | FC-0012 #351
feat!: remove Transifex calls for OEP-58 | FC-0012 #351
Conversation
Thanks for the pull request, @hopewise! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
@hopewise Thank you for this contribution! Please let us know when the changes are ready for review. |
@itsjeyd this is now ready for review. Similar to other Transifex deprecation PRs, it shouldn't be merged yet: We're continuing to create more pull requests like this in a total of ~40 PRs and keep them in draft until we get a greenlight from |
Sounds good @OmarIthawi, thank you for the update. |
I'm doing my best to review this. So I followed the steps in the PR descriptions under "Test Results". I got an error when trying to test locally:
|
fbbae35
to
d2af948
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brian-smith-tcril @itsjeyd this one is ready for merge and approved by 2U
cc: @timmc-edx
Sorry for the delayed feedback @jesperhodge Please either install
This should use the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #351 +/- ##
=======================================
Coverage 53.14% 53.14%
=======================================
Files 80 80
Lines 2021 2021
Branches 368 368
=======================================
Hits 1074 1074
Misses 914 914
Partials 33 33 ☔ View full report in Codecov by Sentry. |
d2af948
to
51253ab
Compare
@brian-smith-tcril rebased. |
7303f79
into
openedx-unsupported:master
@hopewise 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Breaking change!
This change breaks the Jenkins transifex integration which has been deprecated in favor of the new GitHub Transifex App integration as part of OEP-58.
Changes
tx pull
andtx push
commands from the micro-frontend in favorof the
atlas pull
command..json
files will be committed into the repos.src/i18n/index.js
should export and empty array so themake pull_translations
override it with the dynamic list of languages.OPENEDX_ATLAS_PULL
flag to makeatlas pull
the default.Makefile
targets and other files.Test results
make pull_translations
works as expected.make pull_translations test results
Merge timeline
This should only be merged after Translation Infrastructure update OEP-58 is fully implemented.
The timing announcement will be shared by @brian-smith-tcril on #translations-project-fc-0012 Open edX Slack channel.
Keep this pull request as a draft to prevent accidental merge.
Pre-merge checklist
References
This contribution is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.
Up-to-date project overview and details are available in the Approach Memo and Technical Discovery: Translations Infrastructure Implementation document.
Join the conversation on Open edX Slack #translations-project-fc-0012.
Check the links above for full information about the overall project.