This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
fix: import base to docs reqs #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An improvement on this PR: #622
Previously, a version conflict between v2.31.0 and v2.32.3 of the
requestspackage occurred when attempting to do python requirement upgrades. The above PR implemented a hotfix by pinning the requests version >=2.32.3, though we decided that this isn't sustainable.The real problem seemed to be that
docs.innever inherited requirements frombase.in, causing the docs requirements to not account for what version of requests was being downloaded by other requirement files. This PR fixes that.