Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH Request] create new repo frontend-component-notification in openedx #1369

Closed
muhammadadeeltajamul opened this issue Jan 28, 2025 · 3 comments
Assignees
Labels
github-request Request for change to access level or settings in the openedx GitHub organization.

Comments

@muhammadadeeltajamul
Copy link

Firm Name

2U

Urgency

High (< 3 days)

Problem/Request

Name: frontend-component-notification
Visibility: public
Organization: openedx
Default branch name: master
License: GNU AFFERO GENERAL PUBLIC LICENSE v3.0

@openedx/2u-infinity will be maintainers of this repo

Reasoning

We have notification tray in @edx/frontend-component-header-edx. To release notification tray to openedx, notification tray code needs to be in both headers (i.e. @edx/frontend-component-header-edx and @openedx/frontend-component-header). We will move common code in this repo and will create a package for it. Then we can import it in both headers.

@muhammadadeeltajamul muhammadadeeltajamul added the github-request Request for change to access level or settings in the openedx GitHub organization. label Jan 28, 2025
Copy link

Thank you for your report! @openedx/axim-oncall will triage within a business day. Simple requests usually take 2-3 business days to resolve; more complex requests could take longer.

@sarina
Copy link
Contributor

sarina commented Jan 29, 2025

@arbrandes - I am going to confer in #oex-notifications because we may wish this go through product review first

@sarina sarina moved this from Backlog to Blocked in Axim Engineering Tasks Jan 29, 2025
@sarina
Copy link
Contributor

sarina commented Jan 29, 2025

From Slack:

Ve will want this to go through product review before we pull in code into the openedx organization. Some things here:

  • We don't have any detail about this feature. The wiki page is not complete.
  • We cannot view the code. We don't know how much might be 2U-specific and not relevant to the Open edX community

Next steps:

  • Please complete the detail on the wiki pages and submit a product proposal to include the code in the Open edX codebase
  • Consider making the code open-source within the edX code organization so we can inspect it. We can initiate a repo transfer into the openedx org if we approve from a product & code perspective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github-request Request for change to access level or settings in the openedx GitHub organization.
Projects
Status: Done
Development

No branches or pull requests

4 participants