Skip to content

Commit

Permalink
feat: add badge issuance with Credly backend (#2489)
Browse files Browse the repository at this point in the history 
* feat: add badges feature
* chore: update dummy translations
* refactor: squash migrations + text cleanup + resolve conflict
* docs: documentation update

---------

Co-authored-by: Andrii <andrii.hantkovskyi@raccoongang.com>
Co-authored-by: Andrii Hantkovskyi <andrii.hantkovskyi@github.com>
Co-authored-by: KyryloKireiev <kirillkireev888@gmail.com>
Co-authored-by: wowkalucky <wowkalucky@gmail.com>
Co-authored-by: GlugovGrGlib <glugov1998@gmail.com>
  • Loading branch information
@kyrylo-kh @KyryloKireiev
@wowkalucky @GlugovGrGlib
6 people authored Jul 22, 2024
1 parent d9ad5dd commit da22842
Show file tree
Hide file tree
Showing 81 changed files with 7,570 additions and 51 deletions.
16 changes: 16 additions & 0 deletions .annotation_safe_list.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,22 @@ auth.Group:
".. no_pii:": "This model has no PII"
auth.Permission:
".. no_pii:": "This model has no PII"
badges.BadgePenalty:
".. no_pii:": "This model has no PII"
badges.BadgeProgress:
".. pii": "Username"
".. pii_types": other
".. pii_retirement": retained
badges.BadgeRequirement:
".. no_pii:": "This model has no PII"
badges.CredlyOrganization:
".. no_pii:": "This model has no PII"
badges.DataRule:
".. no_pii:": "This model has no PII"
badges.Fulfillment:
".. no_pii:": "This model has no PII"
badges.PenaltyDataRule:
".. no_pii:": "This model has no PII"
credentials.HistoricalProgramCompletionEmailConfiguration:
".. no_pii:": "This model has no PII"
contenttypes.ContentType:
Expand Down
Empty file added credentials/apps/badges/__init__.py
View file
Empty file.
Loading

1 comment on commit da22842

@Silidrone
Copy link

@Silidrone Silidrone commented on da22842 Feb 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In credentials/apps/credentials/issuers.py, I noticed this comment: "This action is idempotent. If the user has already earned the credential, a new one WILL NOT be issued. The existing credential WILL be modified."

This comment needs to be amended, as the second part of the sentence contradicts the first. Idempotence means some function or operation makes no modification beyond the first call to it, whereas here it is clearly pointed out that the function does make modifications on subsequent calls.

Please sign in to comment.