-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [FC-0065] course credentials as verifiable credentials #2674
feat: [FC-0065] course credentials as verifiable credentials #2674
Conversation
Thanks for the pull request, @kyrylo-kh! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
1c56e13
to
0f2911b
Compare
aa84901
to
5e24144
Compare
7350c69
to
89e9f8a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I had some questions but the answers to all of them might be "yeah, that's totally fine."
There is one docstring that needs to be updated but other than that this looks real solid.
89e9f8a
to
272acea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me. thanks for the answers and changes!
272acea
to
ae4ff7e
Compare
Hey @kyrylo-kh apologies for the delay with the review, I will try to publish it today. Meanwhile, could you please add references to Funded Contribution [FC-0065] in the title and PR description? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks great, left one non-blocking comment about older documentation corrections.
LGTM!
ae4ff7e
to
eb62f68
Compare
Description:
Add the ability to generate verifiable credentials for course credentials
Reference to Funded Contribution:
https://openedx.atlassian.net/wiki/spaces/COMM/pages/4574642181/FC-0065+-+Credentials+Enhancements
Related PR's: