Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [FC-0065] course credentials as verifiable credentials #2674

Conversation

kyrylo-kh
Copy link
Contributor

@kyrylo-kh kyrylo-kh commented Jan 2, 2025

Description:
Add the ability to generate verifiable credentials for course credentials

Reference to Funded Contribution:
https://openedx.atlassian.net/wiki/spaces/COMM/pages/4574642181/FC-0065+-+Credentials+Enhancements

Related PR's:

@kyrylo-kh kyrylo-kh requested a review from a team as a code owner January 2, 2025 10:22
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 2, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Jan 2, 2025

Thanks for the pull request, @kyrylo-kh!

This repository is currently maintained by @2U-aperture.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@kyrylo-kh kyrylo-kh changed the title feat: course credentials as verifiable credentials Draft: feat: course credentials as verifiable credentials Jan 2, 2025
@kyrylo-kh kyrylo-kh changed the title Draft: feat: course credentials as verifiable credentials feat: course credentials as verifiable credentials Jan 2, 2025
@kyrylo-kh kyrylo-kh marked this pull request as draft January 2, 2025 10:24
@kyrylo-kh kyrylo-kh force-pushed the feat/course-credentials-as-verifiable-credentials branch from 1c56e13 to 0f2911b Compare January 2, 2025 10:26
@kyrylo-kh kyrylo-kh force-pushed the feat/course-credentials-as-verifiable-credentials branch 7 times, most recently from aa84901 to 5e24144 Compare January 2, 2025 14:21
@kyrylo-kh kyrylo-kh force-pushed the feat/course-credentials-as-verifiable-credentials branch 3 times, most recently from 7350c69 to 89e9f8a Compare January 17, 2025 14:58
@kyrylo-kh kyrylo-kh marked this pull request as ready for review January 17, 2025 15:04
Copy link
Member

@deborahgu deborahgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I had some questions but the answers to all of them might be "yeah, that's totally fine."

There is one docstring that needs to be updated but other than that this looks real solid.

@GlugovGrGlib GlugovGrGlib self-requested a review January 23, 2025 11:31
@kyrylo-kh kyrylo-kh force-pushed the feat/course-credentials-as-verifiable-credentials branch from 89e9f8a to 272acea Compare January 27, 2025 09:08
Copy link
Member

@deborahgu deborahgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. thanks for the answers and changes!

@kyrylo-kh kyrylo-kh force-pushed the feat/course-credentials-as-verifiable-credentials branch from 272acea to ae4ff7e Compare February 10, 2025 10:46
@GlugovGrGlib GlugovGrGlib added the FC Relates to an Axim Funded Contribution project label Feb 11, 2025
@GlugovGrGlib
Copy link
Member

Hey @kyrylo-kh apologies for the delay with the review, I will try to publish it today. Meanwhile, could you please add references to Funded Contribution [FC-0065] in the title and PR description?

@kyrylo-kh kyrylo-kh changed the title feat: course credentials as verifiable credentials feat: [FC-0065] course credentials as verifiable credentials Feb 12, 2025
Copy link
Member

@GlugovGrGlib GlugovGrGlib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great, left one non-blocking comment about older documentation corrections.
LGTM!

@kyrylo-kh kyrylo-kh force-pushed the feat/course-credentials-as-verifiable-credentials branch from ae4ff7e to eb62f68 Compare February 13, 2025 09:30
@deborahgu deborahgu merged commit 96e7b35 into openedx:master Feb 13, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants