feat: allow download of program record even when segment is blocked #2360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we were assuming that segment was always being permitted from the browser side, but segment is blocked as every single privacy built in, including strict tracking protections in the browser. Allow download of the record in that case. FIXES: APER-3164
linter FIXES: APER-3164
linter FIXES: APER-3164
justinhynes
reviewed
Jan 25, 2024
| ["Learner Name", record["learner"]["full_name"]], | ||
| ["Username", record["learner"]["username"]], | ||
| ["Email", record["learner"]["email"]], | ||
| ["Program Name", program.get("name", None)], |
There was a problem hiding this comment.
Thank you for this. Definitely should make it more robust/resilient. 👍
justinhynes
approved these changes
Jan 25, 2024
deborahgu
deleted the
dkaplan1/APER-3164_download-program-record-needs-to-work-when-segment-is-blocked
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we were assuming that segment was always being permitted from the browser side, but segment is blocked by every single privacy built in, including strict tracking protections in the browser. Allow download of the record in that case.
FIXES: APER-3164
Run JavaScript tests locally with Karma
There is work being done on a fix to get Karma to run in CI. Until then, however, contributors are required to run these tests locally.
make test-karma