-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing see also links for txt files #796
fixing see also links for txt files #796
Conversation
Thanks for the pull request, @jesgreco! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think these see also's are thorough enough. Best approach would be to find the navigation section that talks about these tasks, and grab the refs from that.
E.g. for add_html, that is most similar to "Add Text Components" from navigation. Grab those links
Changes to the see also tables were made based on navigation files. |
@jswope00 I think after all my changes this PR is ready for Sarina's review and merge. |
@jesgreco you'll need to eliminate the space in the :ref: links to prevent this kind of error: ![]() |
I'm performing the changes now @jswope00 |
this adding_text is related to add_html.txt which has the see also table based on nav file.
add_video.rst is linked to add_video.txt and both of them need to have see also table based on nav file.
this file is linked to publish_courst.txt
Every file is amended, and tested (build test). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jswope00 please merge when you're satisfied
@jesgreco There are some new conflicts. I think because a commit from Sarina touched most of the See Also links. When you fix them, I think you can probably just take your changes over Sarina's in almost every case since Sarina was just fixing spacing whereas you were building out the right links and fixing spacing. |
Hi @jesgreco! Just following up to see if this is still in progress? |
@mphilbrick211 @sarina I recommend closing this PR unmerged since it has been replaced at this point by In 840, we eliminate the txt files in favor of using snippets of our how-to RST files. So the txt files in this PR end up getting deleted anyway. |
fixing see also links for add_video.txt