-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(FC-68) Jswope00/Update Quickstart to Only use How-to snippets #840
base: main
Are you sure you want to change the base?
Conversation
…jswope00/reorg-educator-other-(FC-68)
…into jswope00/reorg-educator-other-(FC-68)
…move Other section
…s for quickstart.
Thanks for the pull request, @jswope00! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
One thing I'll note is that changing all the ref names will cause the redirects in edx-documentation to fail. I can deal with this, it's just annoying. What do you think the best way for me to review this one is, it's huge... 🙂 |
@sarina I merged main into this PR which greatly reduced the complexity of the review now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
John this looks good to me but I find the sidebar-within-content to be a bit cramped/squished, I posted some screenshots. What do you think?
|
||
.. sidebar:: Edit Multiple Choice Problem | ||
|
||
.. thumbnail:: /_images/Educators_edit_multiple_choice.png |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'm in favor of inline images for all images. I know that a lot of effort was put into the the original quickstart, but given the formatting changes it makes sense now to just shift the images from thumbnail to inline. I'll make the change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Full size images are in the latest commit: 7a62a66
@jswope00 this one still needs to be finished up, it has conflicts now. |
@sarina conflicts resolved, some refs updated, and images changed to full width. Ready for review. |
Update the build_a_course.rst to only use how-to snippets instead of "reusable" txt files. This eliminates redundancy and consolidates us to only using .rst files