revert: temp: remove flaky tests video/transcripts/test_views.py #32719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
It passed the first time. I'll try a few more times. |
|
It passed 5 times in a row. |
)" This reverts commit 6b19eab.
kdmccormick
force-pushed
the
revert-32697-robrap/remove-flaky-cms-test
branch
from
fc8cb45 to
a0771dc
Compare
|
7 times in a row total, including once after rebasing this morning. No failures so far. |
bszabo
approved these changes
Jul 12, 2023
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
timmc-edx
added a commit
that referenced
this pull request
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds back a JS unit test which was identified as flaky in #32690 and removed by #32697.
We are not exactly sure why the test became flaky, although there is speculation that it is related to a Sass build refactoring. Since that refactoring merged, there have been two follow-up fixes, both related to the video block:
I posit that the test became flaky due to a styling bug which the Sass refactoring PR introduced, and was then fixed via the two follow-ups PR. We don't have an easy way to prove or disprove this hypothesis.
Since this PR is consistently passes JavaScript tests, though, I propose we merge it, and then immediately revert again & investigate more deeply if the test returns to being flaky.