Make copied tags editable again after breaking the upstream link to library content [FC-0076]

[pomegranited]

Description

When deleting an upstream library block, ensure that any tags that may have been copied to downstream blocks are made editable again. This is achieved by un-setting the is_copied flag on the downstream tags.

This change affects Content Authors using linked library content.

Supporting information

Part of: openedx/modular-learning#244
Based on: #36111 -- compare changes
Depends on: openedx/openedx-learning#276
Private-ref: FAL-4008

Testing instructions

Note: There's a bug in the Authoring MFE's Course Unit page that prevents the tag drawer from opening. So ensure you have disabled the contentstore.new_studio_mfe.use_new_unit_page waffle flag to use the legacy Studio unit interface during testing.

0. Run migrations to add new link tables.
1. Create a block in a content library, and add some tags to it.
2. Publish the block.
3. Copy the library block into a course, either using the staged content copy/paste, or by adding a Library Content block, and selecting your published block.
   Should see the tags copied from the library block on the new course block, and they should not be deleteable.
4. Add some more tags to the new course block.
   These tags should be deletable.
5. Go back to your content library block, and delete it.
6. Return to the course block, and re-open the "manage tags" sidebar.
   All the tags should remain, and all are deletable now.

Deadline

None

[openedx-webhooks]

Thanks for the pull request, @pomegranited!

This repository is currently maintained by @openedx/wg-maintenance-edx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

---

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[navinkarkera]

@pomegranited Works as expected 💯 Just left a suggestion about using the event to handle the tags, let me know if you disagree.

[navinkarkera]

@pomegranited Thanks! Looks good.

👍

• I tested this: (Followed test instructions)
• I read through the code
• I checked for accessibility issues
• Includes documentation

[navinkarkera]

Since we depend on openedx-events for this to work, it would be safe to explicitly enable the required events to make sure that the test passes (had an issue before with a test case that failed only in CI but passed locally, most probably due to some events being disabled in some previous test in CI).

You can inherit from OpenEdxEventsTestMixin (Note that it should be added before ModuleStoreTestCase) and enable below events.

class ClipboardPasteFromV2LibraryTestCase(OpenEdxEventsTestMixin, ModuleStoreTestCase):
    """
    Test Clipboard Paste functionality with a "new" (as of Sumac) library
    """

    ENABLED_OPENEDX_EVENTS = [
        LIBRARY_BLOCK_DELETED.event_type,
        XBLOCK_UPDATED.event_type,
    ]

[ChrisChV]

Looks good! 👍 I will merge it tomorrow morning

[edx-pipeline-bot]

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

[edx-pipeline-bot]

2U Release Notice: This PR has been deployed to the edX production environment.