-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Separate Publish order sort from publish filter [FC-0076] #1701
base: master
Are you sure you want to change the base?
refactor: Separate Publish order sort from publish filter [FC-0076] #1701
Conversation
Thanks for the pull request, @ChrisChV! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1701 +/- ##
==========================================
- Coverage 93.37% 93.37% -0.01%
==========================================
Files 1110 1110
Lines 22244 22237 -7
Branches 4715 4797 +82
==========================================
- Hits 20770 20763 -7
Misses 1409 1409
Partials 65 65 ☔ View full report in Codecov by Sentry. |
Description
This is a fix for #1484 (comment)
Supporting information
GitHub issue: #1484
Internal link: FAL-4100
Testing instructions
Sory By
toRecently Published
.Publish status
filter doesn't change.recently modified
Other information
N/A