Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed hover color issue throughout MFE #644

Merged
merged 3 commits into from
Jan 16, 2024
Merged

Conversation

sundasnoreen12
Copy link
Contributor

@sundasnoreen12 sundasnoreen12 commented Jan 15, 2024

INF-1220

Description

  1. Updated the direct color codes in scss file with paragon color variables in discussion MFE.
  2. Fixed hover color issue throughout discussion MFE
  3. Fixed ZIndex issue of card

How Has This Been Tested?

Screenshots/sandbox (optional):

Include a link to the sandbox for design changes or screenshot for before and after. Remove this section if it's not applicable.

|Before|After|
Before
Screenshot 2024-01-15 at 1 06 40 PM
After
Screenshot 2024-01-15 at 1 07 59 PM
Before
Screenshot 2024-01-15 at 1 07 21 PM
After
Screenshot 2024-01-15 at 1 08 48 PM
Before
Screenshot 2024-01-15 at 1 11 11 PM
After
Screenshot 2024-01-15 at 1 11 51 PM
Before
Screenshot 2024-01-15 at 11 15 07 PM
After
Screenshot 2024-01-15 at 11 14 42 PM

Post-merge Checklist

  • Deploy the changes to prod after verifying on stage or ask @openedx/edx-infinity to do it.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (92adec3) 92.38% compared to head (e9efc83) 92.38%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #644   +/-   ##
=======================================
  Coverage   92.38%   92.38%           
=======================================
  Files         169      169           
  Lines        3452     3452           
  Branches      892      892           
=======================================
  Hits         3189     3189           
  Misses        243      243           
  Partials       20       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@awais-ansari awais-ansari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a nit. Add border around add comment button.
Screenshot 2024-01-15 at 18 56 24

@sundasnoreen12 sundasnoreen12 merged commit 5df51f2 into master Jan 16, 2024
6 checks passed
@sundasnoreen12 sundasnoreen12 deleted the sundas/INF-1220 branch January 16, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants