Fix: error during post creation in discussion MFE sidebar (#751) #752
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @zameel7! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
mphilbrick211
added
the
needs test run
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #752 +/- ##
=======================================
Coverage 93.17% 93.17%
=======================================
Files 161 161
Lines 3401 3401
Branches 924 923 -1
=======================================
Hits 3169 3169
Misses 214 214
Partials 18 18 ☔ View full report in Codecov by Sentry. |
Adds defensive null checks when accessing post properties in the posts forEach loop to prevent potential errors in the MFE discussion sidebar. This addresses the issue reported in openedx#751.
zameel7
force-pushed
the
zameel7-patch-fix-create-post-mfe-sidebar
branch
from
7f0449c to
80b8279
Compare
|
@e0d, sorry I missed that. Fixed that now. |
mphilbrick211
removed
the
needs test run
|
Hi @openedx/2u-infinity - this is ready for review. Thanks! |
@openedx/2u-infinity friendly ping on this! |
There was a problem hiding this comment.
PR Overview
This PR addresses an error encountered during post creation in the discussion MFE sidebar by adding additional checks for post existence before evaluating the pinned status.
- Added a check to ensure that the post exists before checking if it is pinned.
- Modified the conditional branching to include an additional "else if" clause ensuring that non-pinned posts are only processed if the post exists.
Reviewed Changes
| File | Description |
|---|---|
| src/discussions/posts/data/hooks.js | Added existence checks around post references to prevent errors |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Description
This check for post fixes the issue that is caused in the new MFE discussion sidebar as mentioned in #751
How Has This Been Tested?
Before the change, I was seeing an error after creating a new post, but now it clears the current post data from the form and submits that.
Post-merge Checklist