From 6d70b87d410193c6e7b0be64e757a7eaed0bb53e Mon Sep 17 00:00:00 2001 From: Bilal Qamar <59555732+BilalQamar95@users.noreply.github.com> Date: Fri, 6 Sep 2024 20:55:07 +0500 Subject: [PATCH] test: Remove support for Node 18 (#397) * test: Remove support for Node 18 * refactor: updated lockfile version workflow --- .github/workflows/ci.yml | 5 +---- .github/workflows/lockfileversion-check.yml | 2 +- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 3a1650ee..930b237c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -3,9 +3,6 @@ on: [push, pull_request] jobs: tests: runs-on: ubuntu-latest - strategy: - matrix: - node: [18, 20] steps: - name: Checkout uses: actions/checkout@v4 @@ -14,7 +11,7 @@ jobs: - name: Setup Nodejs uses: actions/setup-node@v4 with: - node-version: ${{ matrix.node }} + node-version-file: '.nvmrc' - name: Install dependencies run: npm ci - name: Validate package-lock.json changes diff --git a/.github/workflows/lockfileversion-check.yml b/.github/workflows/lockfileversion-check.yml index 6ac66558..916dcb40 100644 --- a/.github/workflows/lockfileversion-check.yml +++ b/.github/workflows/lockfileversion-check.yml @@ -10,4 +10,4 @@ on: jobs: version-check: - uses: openedx/.github/.github/workflows/lockfile-check-v20.yml@master + uses: openedx/.github/.github/workflows/lockfileversion-check-v3.yml@master