feat: UI improvements #318

Lunyachek · 2024-04-03T22:15:54Z

Minor fix for Back to My Records button

First proposal: make the button look the same as the button on the records page

Second proposal: remove the <a> tag from the <button> tag. The current approach is not recommended due to potential accessibility and semantic issues

Decrease font size for the Questions about Learner Records title - to match with the same title on Records page

Send Program Record modal window - checkboxes alignment

Before

After

openedx-webhooks · 2024-04-03T22:15:58Z

Thanks for the pull request, @Lunyachek!

This repository is currently maintained by @2U-aperture.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

Dependencies

This PR must be merged before / after / at the same time as ...
Blockers

This PR is waiting for OEP-1234 to be accepted.
Timeline information

This PR must be merged by XX date because ...
Partner information

This is for a course on edx.org.
Supporting documentation
Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

The size and impact of the changes that it introduces
The need for product review
Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

codecov · 2024-04-03T22:26:06Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.01%. Comparing base (323ea5d) to head (ad31639).
Report is 175 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #318      +/-   ##
==========================================
+ Coverage   70.73%   74.01%   +3.28%     
==========================================
  Files          28       28              
  Lines         410      431      +21     
  Branches       87      100      +13     
==========================================
+ Hits          290      319      +29     
+ Misses        119      111       -8     
  Partials        1        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- Minor fix for Back to My Records button - Decrease font size for the Questions about Learner Records title - Send Program Record modal window - checkboxes alignment

mphilbrick211 · 2024-04-05T00:39:31Z

Hi @openedx/2u-aperture! This PR and it's backport are ready for review. Thanks!

deborahgu · 2024-04-10T19:35:06Z

Is this the kind of thing that requires product review (because it's a design change)? And if so, did it get one? (forgive me if I don't understand what needs to go through product review; I'm trying to get a handle on this.)

mphilbrick211 · 2024-04-11T00:19:20Z

Is this the kind of thing that requires product review (because it's a design change)? And if so, did it get one? (forgive me if I don't understand what needs to go through product review; I'm trying to get a handle on this.)

@deborahgu I'll check with Product to see!

deborahgu · 2024-04-11T14:15:45Z

src/components/ProgramRecord/RecordsHelp.jsx

@@ -6,13 +6,13 @@ import { Hyperlink } from '@openedx/paragon';
 function RecordsHelp({ helpUrl }) {
  return (
    <section className="help">
-      <h2>
+      <h3 className="h5">


Why are you switching to a skipped heading level here? The previous heading is h1.

I did it by analogy with this and this files.

the referenced pages aren't best practice, and should eventually be fixed instead of copied 😄 . If you look at the heading list on the programs record list, for example, you can see that Questions about learner records? appears to be one of the program records, so is harder to discover for someone navigating by heading. If it popped back to h2, It would be clearly its own heading, not one of the program records.

src/components/ProgramRecordSendModal/SendLearnerRecordModal.scss

justinhynes

LGTM! Thanks for the fixes. Once this is approved by @deborahgu, I'll take a look at the backport PR too.

justinhynes · 2024-05-20T13:26:44Z

@deborahgu Any additional feedback or suggestions here? Are there any other changes you'd like to see?

deborahgu · 2024-05-20T13:34:32Z

I'm still uncomfortable with the skipped heading level; following a broken pattern is still broken. I think this needs accessibility review.
@mphilbrick211, does this need product review?

mphilbrick211 · 2024-05-20T18:52:39Z

Hi @deborahgu and @justinhynes! I checked in again with @jmakowski1123 and she said this should go through Product review. I've added the label and we'll hold for her team to take a look.

Dismissing review until this has gone through Product review.

justinhynes · 2024-08-14T18:51:52Z

I removed the needs maintainer attention only because this appears to have not been through product review. Once that is finished, we can pick it back as maintainers.

justinhynes · 2024-10-08T12:12:41Z

Hi @mphilbrick211 & @jmakowski1123!

Just following up on this since it's been awhile. Did this ever go through Product Review?

ihor-romaniuk · 2024-12-03T08:46:09Z

Hello everyone,
It seems our pull request for the fix might be a bit stuck in the review process. Would someone be able to take a look at it when they have a moment?
Thank you so much for your time and help!

deborahgu · 2024-12-03T14:12:41Z

This is still awaiting product review (cc @mphilbrick211). And once it's had product review, we're going to require the skipped heading level be addressed for accessibility purposes. Copying broken prior art is still broken.

mphilbrick211 · 2024-12-10T19:47:00Z

This is still awaiting product review (cc @mphilbrick211). And once it's had product review, we're going to require the skipped heading level be addressed for accessibility purposes. Copying broken prior art is still broken.

@deborahgu @jmakowski1123 does a product roadmap ticket exist for this?

deborahgu · 2024-12-10T20:04:19Z

Not as far as I know.

jmakowski1123 · 2025-02-25T17:41:04Z

These look like small enough bugs/style changes that they don't need a full product review. Good to proceed.

deborahgu · 2025-02-25T17:54:38Z

as soon as the skipped heading level is fixed, I'm fine with this. I don't have any opinions about how it is styled, but semantically, for accessibility, we should not be skipping levels.

Lunyachek · 2025-03-03T18:25:47Z

as soon as the skipped heading level is fixed, I'm fine with this. I don't have any opinions about how it is styled, but semantically, for accessibility, we should not be skipping levels.

Understood and agreed :) I have made the changes you mentioned

deborahgu

Looks good to me!

openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 3, 2024

Lunyachek force-pushed the lunyachek/feat/ui-improvements-master branch from 1802de1 to 75ed23b Compare April 3, 2024 22:20

Lunyachek mentioned this pull request Apr 3, 2024

feat: UI improvements #319

Closed

feat: UI improvements

e1accfe

- Minor fix for Back to My Records button - Decrease font size for the Questions about Learner Records title - Send Program Record modal window - checkboxes alignment

Lunyachek force-pushed the lunyachek/feat/ui-improvements-master branch from 75ed23b to e1accfe Compare April 4, 2024 11:18

mphilbrick211 added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Apr 5, 2024

mphilbrick211 requested a review from a team April 5, 2024 00:39

jsnwesson added the needs maintainer attention Issue or PR specifically needs the attention of the maintainer. label Apr 5, 2024

deborahgu added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Apr 10, 2024

deborahgu requested changes Apr 11, 2024

View reviewed changes

feat: After review - remove checkbox fix

0634547

mphilbrick211 removed the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label May 2, 2024

justinhynes previously approved these changes May 20, 2024

View reviewed changes

mphilbrick211 added product review PR requires product review before merging and removed needs maintainer attention Issue or PR specifically needs the attention of the maintainer. labels May 20, 2024

deborahgu added the needs maintainer attention Issue or PR specifically needs the attention of the maintainer. label Jul 16, 2024

justinhynes removed the needs maintainer attention Issue or PR specifically needs the attention of the maintainer. label Aug 14, 2024

mphilbrick211 removed the product review PR requires product review before merging label Mar 3, 2025

feat: After review

ad31639

deborahgu approved these changes Mar 3, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: UI improvements #318

feat: UI improvements #318

Lunyachek commented Apr 3, 2024 •

edited

Loading

openedx-webhooks commented Apr 3, 2024 •

edited

Loading

codecov bot commented Apr 3, 2024 •

edited

Loading

mphilbrick211 commented Apr 5, 2024

deborahgu commented Apr 10, 2024

mphilbrick211 commented Apr 11, 2024

deborahgu Apr 11, 2024

Lunyachek Apr 18, 2024 •

edited

Loading

deborahgu Feb 25, 2025

justinhynes left a comment

justinhynes commented May 20, 2024

deborahgu commented May 20, 2024

mphilbrick211 commented May 20, 2024

justinhynes commented Aug 14, 2024

justinhynes commented Oct 8, 2024

ihor-romaniuk commented Dec 3, 2024

deborahgu commented Dec 3, 2024

mphilbrick211 commented Dec 10, 2024

deborahgu commented Dec 10, 2024

jmakowski1123 commented Feb 25, 2025

deborahgu commented Feb 25, 2025

Lunyachek commented Mar 3, 2025

deborahgu left a comment

feat: UI improvements #318

Are you sure you want to change the base?

feat: UI improvements #318

Conversation

Lunyachek commented Apr 3, 2024 • edited Loading

openedx-webhooks commented Apr 3, 2024 • edited Loading

codecov bot commented Apr 3, 2024 • edited Loading

Codecov Report

mphilbrick211 commented Apr 5, 2024

deborahgu commented Apr 10, 2024

mphilbrick211 commented Apr 11, 2024

deborahgu Apr 11, 2024

Choose a reason for hiding this comment

Lunyachek Apr 18, 2024 • edited Loading

Choose a reason for hiding this comment

deborahgu Feb 25, 2025

Choose a reason for hiding this comment

justinhynes left a comment

Choose a reason for hiding this comment

justinhynes commented May 20, 2024

deborahgu commented May 20, 2024

mphilbrick211 commented May 20, 2024

justinhynes commented Aug 14, 2024

justinhynes commented Oct 8, 2024

ihor-romaniuk commented Dec 3, 2024

deborahgu commented Dec 3, 2024

mphilbrick211 commented Dec 10, 2024

deborahgu commented Dec 10, 2024

jmakowski1123 commented Feb 25, 2025

deborahgu commented Feb 25, 2025

Lunyachek commented Mar 3, 2025

deborahgu left a comment

Choose a reason for hiding this comment

Lunyachek commented Apr 3, 2024 •

edited

Loading

openedx-webhooks commented Apr 3, 2024 •

edited

Loading

codecov bot commented Apr 3, 2024 •

edited

Loading

Lunyachek Apr 18, 2024 •

edited

Loading