fix: fixed empty section issue #1292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sundasnoreen12
requested review from
awais-ansari,
ayesha-waris and
muhammadadeeltajamul
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1292 +/- ##
=======================================
Coverage 88.35% 88.35%
=======================================
Files 291 291
Lines 4938 4938
Branches 1243 1243
=======================================
Hits 4363 4363
Misses 561 561
Partials 14 14 ☔ View full report in Codecov by Sentry. |
awais-ansari
suggested changes
Feb 14, 2024
muhammadadeeltajamul
approved these changes
Feb 15, 2024
awais-ansari
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INF-1254
Description
An empty section is displayed when there are no notifications or discussion bars available for the in-context sidebar.
https://www.loom.com/share/5237ee3f8d5f49c884567cbeb7af5262?sid=ab72518e-4cf4-410b-8be9-ce71969a80fb
A.C
Section shouldn’t be visible when notification and discussion bar are not available for the incontext sidebar.