feat: Update previous and next unit navigation buttons design #1617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1617 +/- ##
==========================================
+ Coverage 84.65% 84.71% +0.05%
==========================================
Files 332 332
Lines 5683 5704 +21
Branches 1359 1404 +45
==========================================
+ Hits 4811 4832 +21
+ Misses 855 853 -2
- Partials 17 19 +2 ☔ View full report in Codecov by Sentry. |
Rodra
force-pushed
the
rodra/update-previous-and-next-unit-navigation-buttons-with-custom-design
branch
2 times, most recently
from
161602f to
4151c66
Compare
|
@Rodra the slack discussion link that you posted is to a private thread. Can you give a summary in the description of the discussion? |
KristinAoki
requested changes
Mar 3, 2025
src/courseware/course/sequence/sequence-navigation/UnitNavigation.jsx
Outdated
Show resolved
Hide resolved
| @@ -47,6 +49,7 @@ export const NextUnitTopNavTriggerSlot : React.FC<Props> = ({ | |||
| nextLink, | |||
| disabled, | |||
| buttonText, | |||
| isAtTop, | |||
There was a problem hiding this comment.
The same change needs to be added to pluginProps
KristinAoki
reviewed
Mar 3, 2025
There was a problem hiding this comment.
Will you remove courseId from the props as it is best practice to fetch inside the plugin via useContext?
Rodra
force-pushed
the
rodra/update-previous-and-next-unit-navigation-buttons-with-custom-design
branch
from
4151c66 to
eba44d5
Compare
Rodra
force-pushed
the
rodra/update-previous-and-next-unit-navigation-buttons-with-custom-design
branch
from
eba44d5 to
f3dddfe
Compare
KristinAoki
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Axim Team:
We've received feedback about the placement of these buttons, and we'd like to make the following change on the open edx platform as well: Move the previous and next buttons at the top of the page down (in line with the content header). For this reason, I think it should be OK to make this change within the MFE itself.
Description
The top previous and next buttons should be moved to match the design pictured below and attached.
There is a requirement from support to make sure the bottom of the page previous and next buttons remain
After
Caveat
Since there's an already margin and padding for the unit content the arrow buttons were added within the inside content without affecting that design. The wanted changes locate the buttons as if there was no margin but we are not skipping this default configuration unless is requested.