Refactor use of frontend-lib-special-exams public API to use hooks. #1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelroytman
force-pushed
the
michaelroytman/COSMO-175-use-refactored-exams-API-hooks
branch
from
c829607 to
ff7f9cd
Compare
michaelroytman
commented
Feb 6, 2024
| @@ -12,14 +12,23 @@ export const stateKeys = StrictDict({ | |||
| const useExamAccess = ({ | |||
| id, | |||
| }) => { | |||
| const [accessToken, setAccessToken] = useKeyedState(stateKeys.accessToken, ''); | |||
There was a problem hiding this comment.
We no longer need to maintain this as state, since the useExamAccessToken hook takes care of getting the updated values from the specialExams store.
michaelroytman
commented
Feb 6, 2024
| @@ -1,98 +0,0 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
The diff is showing up this way, because I had to rename this from a js file to a jsx file.
michaelroytman
commented
Feb 6, 2024
| @@ -0,0 +1,88 @@ | |||
| import { logError } from '@edx/frontend-platform/logging'; | |||
There was a problem hiding this comment.
I used the article How to test custom React hooks to decide how to test this hook. I decided to focus on testing the return values instead of the internals of the hook, since that may change (as it did in this pull request). I think these tests will be more stables this way.
alangsto
approved these changes
Feb 7, 2024
This commit refactors the use of the frontend-lib-special-exams public API to use hooks. This commit also imports the root reducer from the frontend-lib-special-exams library. This root reducer is used for the specialExams slice when configuring the store for this application.
alangsto
force-pushed
the
michaelroytman/COSMO-175-use-refactored-exams-API-hooks
branch
from
64fa556 to
a8fcd75
Compare
alangsto
deleted the
michaelroytman/COSMO-175-use-refactored-exams-API-hooks
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Jira: COSMO-175
NOTE: The corresponding pull request in
frontend-lib-special-examsis a prerequisite to these changes: openedx/frontend-lib-special-exams#134. Those changes must be merged and deployed and the version of the library updated here before these changes can be merged.This commit refactors the use of the
frontend-lib-special-examspublic API to use hooks.This commit also imports the root reducer from the
frontend-lib-special-examslibrary. This root reducer is used for the specialExams slice when configuring the store for this application.