Skip to content

Commit

Permalink
fix: overrideHeaderConfig’s base param is a ResolvedHeaderConfig
Browse files Browse the repository at this point in the history
In that all the properties MUST be defined in the base.
  • Loading branch information
davidjoy committed Oct 24, 2024
1 parent 922d18f commit a8bcd7a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion shell/header/data/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export function isDropdownMenuItem(item: MenuItem): item is DropdownMenuItem {
return item && typeof item === 'object' && 'items' in item;
}

function overrideHeaderConfig(base: HeaderConfig, override: HeaderConfig) {
function overrideHeaderConfig(base: ResolvedHeaderConfig, override: HeaderConfig) {
if (override.logoUrl !== undefined) {
base.logoUrl = override.logoUrl;
}
Expand Down

0 comments on commit a8bcd7a

Please sign in to comment.