Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily Re-Introduce Studio Maintenance Header Link #565

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

kdmccormick
Copy link
Member

@kdmccormick kdmccormick commented Jan 14, 2025

Reverts #553

We are temporarily re-introducing the Maintenance link, as the Maintenance Announcements tool is still in use, as discussed on: openedx/edx-platform#35852

This PR depends on this related revert PR: openedx/edx-platform#36107

@kdmccormick kdmccormick marked this pull request as draft January 14, 2025 20:38
@kdmccormick kdmccormick marked this pull request as ready for review January 14, 2025 20:38
@kdmccormick kdmccormick marked this pull request as draft January 14, 2025 20:39
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.75%. Comparing base (edb2231) to head (1fb25fe).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #565   +/-   ##
=======================================
  Coverage   68.75%   68.75%           
=======================================
  Files          48       48           
  Lines         432      432           
  Branches       97       97           
=======================================
  Hits          297      297           
  Misses        132      132           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kdmccormick kdmccormick changed the title revert: fix: Remove Studio Maintenance link Temporarily Re-Introduce Studio Maintenance link Feb 14, 2025
@kdmccormick kdmccormick changed the title Temporarily Re-Introduce Studio Maintenance link Temporarily Re-Introduce Studio Maintenance Header Link Feb 14, 2025
@kdmccormick kdmccormick marked this pull request as ready for review February 14, 2025 22:40
Copy link
Member

@Agrendalath Agrendalath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I tested this: I didn't test it, but it's a clean revert
  • I read through the code
  • I checked for accessibility issues: n/a
  • Includes documentation: n/a

@kdmccormick kdmccormick merged commit 48c49fe into master Feb 19, 2025
6 checks passed
@kdmccormick kdmccormick deleted the revert-553-kdmccormick/cms-maintenance-depr branch February 19, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants