feat: added datadog logging adapter #684
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dullahwaheed/datadog-testing
schenedx
reviewed
May 1, 2024
.env.development
Outdated
| SUPPORT_URL=https://support.edx.org | ||
| DATADOG_ENABLED=false |
There was a problem hiding this comment.
Could you please keep this list alphabetized? So, insert this line into line 8?
| @@ -35,8 +35,8 @@ | |||
| "devDependencies": { | |||
| "@edx/brand": "npm:@openedx/brand-openedx@^1.2.2", | |||
| "@edx/browserslist-config": "1.2.0", | |||
| "@openedx/frontend-build": "14.0.3", | |||
| "@openedx/paragon": "22.3.1", | |||
| "@openedx/frontend-build": "github:openedx/frontend-build#abdullahwaheed/datadog-logging", | |||
There was a problem hiding this comment.
Are you planning to merge this change to master? Or just use this branch on an MFE for testing first?
There was a problem hiding this comment.
no, we'll first merge it in alpha to test it
abdullahwaheed
changed the title
|
@abdullahwaheed Is it OK to close this PR at this point? |
|
yes, this was testing PR. closing it now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Describe what this pull request changes, and why. Include implications for people using this change.
Merge checklist:
frontend-platform. This can be done by runningnpm startand opening http://localhost:8080.module.config.jsfile infrontend-build.fix,feat) and is appropriate for your code change. Consider whether your code is a breaking change, and modify your commit accordingly.Post merge: