-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Updating Python Requirements #304
Conversation
Thanks for the pull request, @mariajgrimaldi! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks good to me. @mariajgrimaldi I think you can go ahead and merge as needed
@@ -11,3 +11,6 @@ | |||
|
|||
# Latest previous version has issues with doc8 because of conflicting docutils constraints | |||
sphinx-book-theme==0.4.0rc1 | |||
|
|||
# Temporary solution since this version raises RecursionError for test_generate_avro_schemas.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[curious] do we have any plans to every so often go test removing the constrains in this list so as to not make temporary fixes live forever?
Not a blocker by any means.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm planning on waiting for the next astroid release to see if it's solved since the error it's from the package itself. In the meantime, I'll look over the code to figure out why it's failing with only that package. I'll include this removal plan in the in-line comment. Thansk!
caa9562
to
4e7e273
Compare
4e7e273
to
b78d72d
Compare
@mariajgrimaldi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This PR contains package updates with a new temporary constraint to avoid the error raised in this PR by astroid:
#302
https://github.com/openedx/openedx-events/actions/runs/7604751496/job/20708053191#step:6:363