-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: [FC-0074] address docs reviews #260
Conversation
Thanks for the pull request, @mariajgrimaldi! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
1d4d5cb
to
dc33c0b
Compare
@BryanttV, thank you so much for the feedback! Here's the PR with the suggested changes for you to review :) |
docs/how-tos/create-a-new-filter.rst
Outdated
course_key (CourseKey): course key associated with the enrollment. | ||
mode (str): is a string specifying what kind of enrollment. | ||
mode (str): specifies what kind of enrollment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a shortlist of modes, or can it be anything? I don't remember how enrollment works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a shortlist of modes: https://edx.readthedocs.io/projects/open-edx-building-and-running-a-course/en/latest/glossary.html#enrollment-track-g. I added the course modes available in the docstring to be more specific :)
Improve how-to docs based on reviews: - Update filter in create-new-filter to match latest standards - Add note about docstring specification - Add sample code for triggering filter - Fix sample code from create-pipeline-step - Format sample codes - Add note about annotating arguments and return
00c5265
to
19c568b
Compare
Description
Improve how-to docs based on reviews:
Deadline
"None" if there's no rush, or provide a specific date or event (and reason) if there is one.
Other information
Include anything else that will help reviewers and consumers understand the change.
Checklists
Check off if complete or not applicable:
Merge Checklist:
Post Merge:
finished.