Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [FC-0074] address docs reviews #260

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

mariajgrimaldi
Copy link
Member

@mariajgrimaldi mariajgrimaldi commented Feb 13, 2025

Description

Improve how-to docs based on reviews:

Deadline

"None" if there's no rush, or provide a specific date or event (and reason) if there is one.

Other information

Include anything else that will help reviewers and consumers understand the change.

  • Any other PRs or issues that should be linked here? Any related PRs?
  • Any special concerns or limitations? For example: deprecations, security, or anything you think should be noted.

Checklists

Check off if complete or not applicable:

Merge Checklist:

  • All reviewers approved
  • Reviewer tested the code following the testing instructions
  • CI build is green
  • Version bumped
  • Changelog record added with short description of the change and current date
  • Documentation updated (not only docstrings)
  • Code dependencies reviewed
  • Fixup commits are squashed away
  • Unit tests added/updated
  • Noted any: Concerns, dependencies, migration issues, deadlines, tickets

Post Merge:

  • Create a tag
  • Create a release on GitHub
  • Check new version is pushed to PyPI after tag-triggered build is
    finished.
  • Delete working branch (if not needed anymore)
  • Upgrade the package in the Open edX platform requirements (if applicable)

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 13, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Feb 13, 2025

Thanks for the pull request, @mariajgrimaldi!

This repository is currently maintained by @openedx/hooks-extension-framework.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@mariajgrimaldi mariajgrimaldi force-pushed the MJG/address-0074-feedback branch 2 times, most recently from 1d4d5cb to dc33c0b Compare February 14, 2025 07:32
@mariajgrimaldi mariajgrimaldi marked this pull request as ready for review February 14, 2025 07:38
@mariajgrimaldi mariajgrimaldi requested a review from a team as a code owner February 14, 2025 07:38
@mariajgrimaldi mariajgrimaldi requested review from sarina, BryanttV and Apgomeznext and removed request for a team February 14, 2025 07:38
@mariajgrimaldi
Copy link
Member Author

@BryanttV, thank you so much for the feedback! Here's the PR with the suggested changes for you to review :)

@mariajgrimaldi mariajgrimaldi changed the title refactor: address docs reviews refactor: [FC09974] address docs reviews Feb 19, 2025
@mariajgrimaldi mariajgrimaldi changed the title refactor: [FC09974] address docs reviews refactor: [FC-0074] address docs reviews Feb 19, 2025
@mariajgrimaldi mariajgrimaldi added the FC Relates to an Axim Funded Contribution project label Feb 19, 2025
course_key (CourseKey): course key associated with the enrollment.
mode (str): is a string specifying what kind of enrollment.
mode (str): specifies what kind of enrollment.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a shortlist of modes, or can it be anything? I don't remember how enrollment works.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a shortlist of modes: https://edx.readthedocs.io/projects/open-edx-building-and-running-a-course/en/latest/glossary.html#enrollment-track-g. I added the course modes available in the docstring to be more specific :)

Improve how-to docs based on reviews:
- Update filter in create-new-filter to match latest standards
- Add note about docstring specification
- Add sample code for triggering filter
- Fix sample code from create-pipeline-step
- Format sample codes
- Add note about annotating arguments and return
@mariajgrimaldi mariajgrimaldi force-pushed the MJG/address-0074-feedback branch from 00c5265 to 19c568b Compare February 19, 2025 16:46
@mariajgrimaldi mariajgrimaldi merged commit e1afb6b into main Feb 19, 2025
11 checks passed
@mariajgrimaldi mariajgrimaldi deleted the MJG/address-0074-feedback branch February 19, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants