-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: rename course_authoring subdomain to content_authoring #252
Conversation
Thanks for the pull request, @mariajgrimaldi! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change itself makes a lot of sense.
The filter has not been up too long so there are likely very few users (only edunext maybe). I think the migration plan is good for this case.
b09679f
to
f8ee965
Compare
Correctly name authoring subdomain according to DDD docs: https://openedx.atlassian.net/wiki/spaces/AC/pages/663224968/edX+DDD+Bounded+Contexts
f8ee965
to
e64cc7a
Compare
Description
When reviewing #200, I suggested using the subdomain
course_authoring
when in reality, it was calledcontent_authoring
. This PR correctly names the authoring subdomain tocontent_authoring
according to the DDD docs for the Open edX ecosystem: https://openedx.atlassian.net/wiki/spaces/AC/pages/663224968/edX+DDD+Bounded+ContextsHere is the PR fixing the subdomain name in edx-platform: openedx/edx-platform#36109
Deadline
ASAP to avoid implementing more filters in the wrong subdomain.
Checklists
Check off if complete or not applicable:
Merge Checklist:
Post Merge:
finished.