Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[paragon-openedx.netlify.app] Feedback (on /components/toast/) Duplicating the "alert" role in the Toast component #3409

Closed
PKulkoRaccoonGang opened this issue Feb 3, 2025 · 2 comments
Assignees

Comments

@PKulkoRaccoonGang
Copy link
Contributor

In the current implementation of the Toast component, we render this component inside the React portal. At the moment, the alert role is present both for the alert wrapper (the element with the toast-container class) and for the alert itself (the element with the pgn__toast class).

Should the alert role be specified only for the alert itself (the element with the pgn__toast class), or for the wrapper (the element with the toast-container class)? The main idea is to keep the element with the alert role in one instance.

Image

@adamstankiewicz
Copy link
Member

Interesting, I agree having the duplicate role="alert" doesn't seem correct. I wonder if the same could also be said for the aria-atomic (same value) and aria-live (competing values), per your screenshot above.

@PKulkoRaccoonGang
Copy link
Contributor Author

Good catch! I also think this is unnecessary duplication. Removed in this commit: 90d695f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants