Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] test commitlint file download #3438

Conversation

brian-smith-tcril
Copy link
Contributor

Description

Include a description of your changes here, along with a link to any relevant Jira tickets and/or Github issues.

Deploy Preview

Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please request an a11y review for the PR in the #wg-paragon Open edX Slack channel.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

adamstankiewicz and others added 4 commits January 31, 2025 08:09
… use of Pagination component (openedx#3406)

This commit fixes a bug with the TablePagination component. This component renders the Pagination component without a paginationLabel prop, which is a required prop of the Pagination component. This commit adds a paginationLabel="table pagination" prop, which matches the prop passed to the PaginationComponent by the TablePaginationMinimal component.

Authored-by: michaelroytman <mroytman@edx.org>
Copy link

netlify bot commented Feb 19, 2025

Deploy Preview for paragon-openedx-v23 ready!

Name Link
🔨 Latest commit d83c762
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx-v23/deploys/67b5e9709b1f9100087027f5
😎 Deploy Preview https://deploy-preview-3438--paragon-openedx-v23.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brian-smith-tcril brian-smith-tcril deleted the test-commitlint-file-download branch February 19, 2025 14:25
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 81.81818% with 4 lines in your changes missing coverage. Please review.

Project coverage is 93.86%. Comparing base (e4ccd26) to head (d83c762).
Report is 4 commits behind head on release-23.x.

Files with missing lines Patch % Lines
src/Hyperlink/index.tsx 78.94% 4 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-23.x    #3438      +/-   ##
================================================
- Coverage         93.91%   93.86%   -0.06%     
================================================
  Files               232      233       +1     
  Lines              3943     3958      +15     
  Branches            901      942      +41     
================================================
+ Hits               3703     3715      +12     
- Misses              236      239       +3     
  Partials              4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants