-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixed Logistration page display issue #3451
base: release-22.x
Are you sure you want to change the base?
fix: fixed Logistration page display issue #3451
Conversation
✅ Deploy Preview for paragon-openedx-v22 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-22.x #3451 +/- ##
=============================================
Coverage 93.40% 93.40%
=============================================
Files 252 252
Lines 4534 4535 +1
Branches 1061 1025 -36
=============================================
+ Hits 4235 4236 +1
- Misses 292 296 +4
+ Partials 7 3 -4 ☔ View full report in Codecov by Sentry. |
I'm having trouble replicating this issue. Can you outline some testing instructions to help reviewers replicate the issue? Presumably this is related to browsers' native auto-fill support of form fields, given the addition of an It would also be helpful to understand how the proposed Using Chrome's auto-fill (see below screen recording), for example, when I hover over the password I want to auto-fill, I see that the auto-filled password overlays the input's placeholder label. However, when I apply the auto-fill, the More generally, I'm also curious if you've dug into why paragon_form_control_autofill_bug_replication_attempt.mov |
Hi @adamstankiewicz , The issue occurs when a user has previously saved their email and password for the login screen. Upon refreshing the login page, the browser automatically fills in the saved credentials. However, since the page is not focused on load, the text and placeholders overlap. The issue resolves once the user clicks anywhere on the screen. On initial page load, the tag does not have a value attribute until the user interacts with the page. The hasValue check does not evaluate as truthy in this scenario because its value depends on props.value. Since autofill populates the fields without triggering a focus event, props.value remains empty initially. I am attaching the frontend PR (openedx/frontend-app-authn#1431) to provide more context on how we are passing the isAutoFill boolean variable. Let me know if you have any further questions. |
Description
INF-1786
The email and password input fields on the login form are overlapping.
Expected Behaviour: When a user enters text into these fields, the entered characters should ideally replace any placeholder text.
Current Behaviour: Currently, the entered text overlaps the original placeholder input.
Solution
Fixed Logistration page display issue due to auto fill.
Merge Checklist
Post-merge Checklist